[GitHub] [ignite] NSAmelchev commented on a change in pull request #7787: IGNITE-12961: Add snapshot create command to control.sh

[GitBox <gi...@apache.org>]

NSAmelchev commented on a change in pull request #7787:
URL: https://github.com/apache/ignite/pull/7787#discussion_r426734614



##########
File path: modules/core/src/test/java/org/apache/ignite/util/GridCommandHandlerTest.java
##########
@@ -2089,4 +2089,28 @@ public void testMasterKeyChangeOnInactiveCluster() throws Exception {
 
         assertContains(log, testOut.toString(), "Master key change was rejected. The cluster is inactive.");
     }
+
+    /** @throws Exception If failed. */
+    @Test
+    public void testClusterSnapshotCreate() throws Exception {
+        Ignite ignite = startGrids(2);
+        ignite.cluster().state(ACTIVE);
+
+        createCacheAndPreload(ignite, 10);
+
+        CommandHandler h = new CommandHandler();
+
+        assertEquals(EXIT_CODE_OK, execute(h, "--snapshot", "create", "snapshot_02052020"));

Review comment:
       Let's check that a snapshot was created with provided name.

##########
File path: modules/core/src/main/java/org/apache/ignite/internal/visor/snapshot/VisorSnapshotCreateTask.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.visor.snapshot;
+
+import org.apache.ignite.IgniteException;
+import org.apache.ignite.IgniteSnapshot;
+import org.apache.ignite.internal.commandline.snapshot.SnapshotCommand;
+import org.apache.ignite.internal.processors.cache.persistence.snapshot.SnapshotMXBeanImpl;
+import org.apache.ignite.internal.processors.task.GridInternal;
+import org.apache.ignite.internal.visor.VisorJob;
+import org.apache.ignite.internal.visor.VisorOneNodeTask;
+
+/**
+ * @see SnapshotCommand
+ * @see IgniteSnapshot#createSnapshot(String)
+ */
+@GridInternal
+public class VisorSnapshotCreateTask extends VisorOneNodeTask<String, Void> {
+    /** Serial version uid. */
+    private static final long serialVersionUID = 0L;
+
+    /** {@inheritDoc} */
+    @Override protected VisorJob<String, Void> job(String arg) {
+        return new VisorSnapshotCreateJob(arg, debug);
+    }
+
+    /** */
+    private static class VisorSnapshotCreateJob extends VisorJob<String, Void> {
+        /** Serial version uid. */
+        private static final long serialVersionUID = 0L;
+
+        /**
+         * @param name Snapshot name.
+         * @param debug Flag indicating whether debug information should be printed into node log.
+         */
+        protected VisorSnapshotCreateJob(String name, boolean debug) {
+            super(name, debug);
+        }
+
+        /** {@inheritDoc} */
+        @Override protected Void run(String name) throws IgniteException {
+            new SnapshotMXBeanImpl(ignite.context()).createSnapshot(name);
+
+            return null;

Review comment:
       I suggest that success command execution prints an informative message. For example, the snapshot was(will be) created. And how to monitor the status.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org