You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "Dave Johnson (JIRA)" <ji...@apache.org> on 2009/06/06 17:14:07 UTC
[jira] Resolved: (ROL-1803) Comments.jsp
[ https://issues.apache.org/jira/browse/ROL-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Johnson resolved ROL-1803.
-------------------------------
Resolution: Fixed
Fix Version/s: 5.0
See previous comments for earlier commit.
This one fixes the end-date issue in the comment bean classes:
URL: http://svn.apache.org/viewvc?rev=782269&view=rev
And that resolves this issue in the trunk.
Thanks Greg!
> Comments.jsp
> -------------
>
> Key: ROL-1803
> URL: https://issues.apache.org/jira/browse/ROL-1803
> Project: Roller
> Issue Type: Bug
> Affects Versions: 5.0
> Reporter: Greg Huber
> Assignee: Dave Johnson
> Priority: Trivial
> Fix For: 5.0
>
>
> hello,
> In comments.jsp there is a line #334 <s:if test="#comment.content.length > 1000"> this needs to be
> <s:if test="#comment.content.length() > 1000"> for it to work, ie .length(). The servlet will never get used!
> Also, possibly in CommentsBean/GlobalCommentsBean, to make more sense for the query:
> public Date getEndDate() {
> if(!StringUtils.isEmpty(getEndDateString()))
> try {
> DateFormat df = new SimpleDateFormat("MM/dd/yy");
> return df.parse(getEndDateString());
> } catch(Exception e) { }
> return null;
> }
> needs to be:
> public Date getEndDate() {
> if(!StringUtils.isEmpty(getEndDateString()))
> try {
> DateFormat df = new SimpleDateFormat("MM/dd/yy");
> //return df.parse(getEndDateString());
> return DateUtil.getEndOfDay(newDate); <<<<<<<<<<<<<<<<<
> } catch(Exception e) { }
> return null;
> }
> Cheers Greg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.