You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/07/07 08:49:24 UTC
[GitHub] zeppelin pull request #1143: [ZEPPELIN-1085] Make dropdown menu scrollbar al...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1143
[ZEPPELIN-1085] Make dropdown menu scrollbar always visible
### What is this PR for?
In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in #1004.
Originally the scroll bar is shown up when user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu. See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085).
So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x).
In short, it says
>There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences).
### What type of PR is it?
Improvement
### TODO
- [x] : test this in major browsers
### What is the Jira issue?
[ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085)
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
- Before : scrollbar is only shown up when you are trying to scroll up & down
- After : always visible
- In case of IE, you can always see the scrollbar. So it's not a problem originally.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1085
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1143
----
commit 4d10883bccb821b927c739b76ea0e455c00b8e51
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-07-07T06:32:28Z
Make dropdown menu scrollbar always visible
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1143: [ZEPPELIN-1085] Make dropdown menu scrollbar always vi...
Posted by jeffsteinmetz <gi...@git.apache.org>.
Github user jeffsteinmetz commented on the issue:
https://github.com/apache/zeppelin/pull/1143
LGTM
At least in Firefox, the scroll bar now displays for a few seconds (doesn't stay, but its an improvement).
Chrome and Safari work as expected.
Tested with:
- Chrome on OSX: Version 51.0.2704.103 (64-bit)
- Safari: Version 9.1.1 (10601.6.17)
- Firefox on OSX: 47.0.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1143: [ZEPPELIN-1085] Make dropdown menu scrollbar always vi...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1143
Thanks @AhyoungRyu for improvement.
Tested with Chrome and Safari. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1143: [ZEPPELIN-1085] Make dropdown menu scrollbar always vi...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1143
Merge it into master if there is no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1143: [ZEPPELIN-1085] Make dropdown menu scrollbar always vi...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1143
@jeffsteinmetz It will be appreciate if you can review this PR as a reporter of this issue :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1143: [ZEPPELIN-1085] Make dropdown menu scrollbar al...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1143: [ZEPPELIN-1085] Make dropdown menu scrollbar always vi...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1143
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1143: [ZEPPELIN-1085] Make dropdown menu scrollbar always vi...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1143
@jeffsteinmetz Right. So Firefox users can know they can scroll down and there is more menus even though this PR couldn't be applied to Firefox.
Thanks for testing this @Leemoonsoo @jeffsteinmetz :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---