You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/12 06:47:52 UTC
[GitHub] [airflow] BasPH commented on a change in pull request #8257:
[docs-only] Simplify language re roll-your-own secrets backend
BasPH commented on a change in pull request #8257: [docs-only] Simplify language re roll-your-own secrets backend
URL: https://github.com/apache/airflow/pull/8257#discussion_r407153193
##########
File path: docs/howto/use-alternative-secrets-backend.rst
##########
@@ -308,19 +308,14 @@ of the connection object.
Roll your own secrets backend
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend`, and just has to implement the
-:py:meth:`~airflow.secrets.BaseSecretsBackend.get_connections` method.
+A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend` and must implement either
+:py:meth:`~airflow.secrets.BaseSecretsBackend.get_connections` or :py:meth:`~airflow.secrets.BaseSecretsBackend.get_connections`.
Review comment:
I now says you must either one of the same method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services