[GitHub] [buildstream] gtristan commented on issue #1349: Make element selection consistent across commands

[GitBox <gi...@apache.org>]

gtristan commented on issue #1349:
URL: https://github.com/apache/buildstream/issues/1349#issuecomment-937644617


   Note, the `--deps plan` option is removed by #1520
   
   What remains here is to have consistency for `--except` options, here is a run down of the situation:
   * The `--except` option does not make sense in `bst build`, even though `bst build` has a `--deps` option, in that case, it selects what elements are imperative targets, but other elements will be built on an as-needed basis
     * One could make a case for `--except` being meaningful with `bst build --deps all`, where `all` falls outside of the required build plan, however it seems unlikely to be particularly useful or intuitive
   * The `bst show` and all of the `bst source *` commands have a `--deps` option, and they also have a `--except option`
   * The `bst artifact *` command group has `--deps` options but does *not* have an `--except` option
     * This command group has the ability to load artifacts without a project, directly using the artifact names, we cannot currently support `--except` for artifact names as we lack the full dependency graph (it is automatically fetched for toplevel artifact name targets, but the full inter-element dependency graph is unavailable until the artifacts are in the local cache)
     * We could support `--except` in `bst artifact *` commands, and specify that it applies only to artifacts loaded by their element names
       * `bst artifact show`: This is easily implementable for element names
       * `bst artifact checkout`: This is very tricky, since we go through the `Element._prepare_sandbox()` route and support running integration commands - it does not seem worthwhile to support this contorted activity especially in light that the user could use a combination of `bst show` and `bst artifact checkout --deps none` to accomplish a similar result
       * `bst artifact pull`, `bst artifact push`, `bst artifact show` and `bst artifact delete`: it is easily implementable for artifacts loaded via element names


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org