You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ibessonov (via GitHub)" <gi...@apache.org> on 2023/05/29 13:25:26 UTC
[GitHub] [ignite-3] ibessonov opened a new pull request, #2114: IGNITE-19398 ItIgniteNodeRestartTest optimized.
ibessonov opened a new pull request, #2114:
URL: https://github.com/apache/ignite-3/pull/2114
https://issues.apache.org/jira/browse/IGNITE-19398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2114: IGNITE-19398 ItIgniteNodeRestartTest optimized.
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #2114:
URL: https://github.com/apache/ignite-3/pull/2114#discussion_r1209821860
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2467,9 +2467,9 @@ public CompletableFuture<?> onUpdate(ConfigurationNotificationEvent<TableIndexVi
boolean casResult = indexesConfigurationListener.compareAndSet(null, listener);
- assert casResult : replicationGroupId;
-
- mvTableStorage.tablesConfiguration().indexes().listenElements(listener);
+ if (casResult) {
Review Comment:
```suggestion
// TODO IGNITE-19053 Fix this workaround.
if (casResult) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2114: IGNITE-19398 ItIgniteNodeRestartTest optimized.
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov commented on code in PR #2114:
URL: https://github.com/apache/ignite-3/pull/2114#discussion_r1209821860
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2467,9 +2467,9 @@ public CompletableFuture<?> onUpdate(ConfigurationNotificationEvent<TableIndexVi
boolean casResult = indexesConfigurationListener.compareAndSet(null, listener);
- assert casResult : replicationGroupId;
-
- mvTableStorage.tablesConfiguration().indexes().listenElements(listener);
+ if (casResult) {
Review Comment:
```suggestion
// TODO IGNITE-19053 Fix this warkaround.
if (casResult) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2114: IGNITE-19398 ItIgniteNodeRestartTest optimized.
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #2114:
URL: https://github.com/apache/ignite-3/pull/2114#discussion_r1209813741
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2467,9 +2467,9 @@ public CompletableFuture<?> onUpdate(ConfigurationNotificationEvent<TableIndexVi
boolean casResult = indexesConfigurationListener.compareAndSet(null, listener);
- assert casResult : replicationGroupId;
-
- mvTableStorage.tablesConfiguration().indexes().listenElements(listener);
+ if (casResult) {
Review Comment:
Please add todo with IGNITE-19053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #2114: IGNITE-19398 ItIgniteNodeRestartTest optimized.
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov merged PR #2114:
URL: https://github.com/apache/ignite-3/pull/2114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org