You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2017/05/22 23:12:06 UTC
Review Request 59469: Code improvement as recommended by good coding
practices
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59469/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-1603
https://issues.apache.org/jira/browse/RANGER-1603
Repository: ranger
Description
-------
Refactored resource-matcher for clarity/readability and adherence to good coding practices. Added more unit tests.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 8c47df2
agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json 86da28c
Diff: https://reviews.apache.org/r/59469/diff/1/
Testing
-------
Compiled, ran and passed all unit tests.
Thanks,
Abhay Kulkarni
Re: Review Request 59469: Code improvement as recommended by good
coding practices
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59469/#review175727
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 22, 2017, 11:12 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59469/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 11:12 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-1603
> https://issues.apache.org/jira/browse/RANGER-1603
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Refactored resource-matcher for clarity/readability and adherence to good coding practices. Added more unit tests.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 8c47df2
> agents-common/src/test/resources/resourcematcher/test_resourcematcher_path.json 86da28c
>
>
> Diff: https://reviews.apache.org/r/59469/diff/1/
>
>
> Testing
> -------
>
> Compiled, ran and passed all unit tests.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>