You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "Maarten Coene (JIRA)" <ji...@apache.org> on 2010/05/07 22:12:49 UTC
[jira] Updated: (IVY-1118) IvyNodeEviction.cleanEvicted has bad
comparison logic
[ https://issues.apache.org/jira/browse/IVY-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene updated IVY-1118:
-------------------------------
Fix Version/s: 2.2.0-RC1
(was: trunk)
> IvyNodeEviction.cleanEvicted has bad comparison logic
> -----------------------------------------------------
>
> Key: IVY-1118
> URL: https://issues.apache.org/jira/browse/IVY-1118
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Reporter: Dave Brosius
> Assignee: Maarten Coene
> Priority: Minor
> Fix For: 2.2.0-RC1
>
>
> clean evicted compares an IvyNode to an IvyNodeEviction which will always be false
> private void cleanEvicted() {
> // check if it was evicted by a node that we are now the real node for
> for (Iterator iter = evicted.keySet().iterator(); iter.hasNext();) {
> String rootModuleConf = (String) iter.next();
> EvictionData ed = (EvictionData) evicted.get(rootModuleConf);
> Collection sel = ed.getSelected();
> if (sel != null) {
> for (Iterator iterator = sel.iterator(); iterator.hasNext();) {
> IvyNode n = (IvyNode) iterator.next();
> if (n.getRealNode().equals(this)) { <<<<<<<<<<<<<<<<<<<<<<<<
> // yes, we are the real node for a selected one !
> // we are no more evicted in this conf !
> iter.remove();
> }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.