You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/10/09 16:34:17 UTC
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11625
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
This patch reverses the revert of IMPALA-7660.
The problem with IMPALA-7660 was that urllib.urlopen added the
'context' parameter in 2.7.9, so it isn't present on rhel7, which uses
2.7.5
urllib.urlopen has been deprecated since 2.6 anyways, so the fix is to
switch to using the more current urllib2.
This patch also adds more info to the error message printed by
start-impala-cluster.py when the debug webserver cannot be reached yet
to help with debugging these issues in the future.
Testing:
- Ran a full build on rhel7
Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
4 files changed, 89 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/11625/1
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Pooja Nilangekar, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11625
to look at the new patch set (#3).
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
This patch reverses the revert of IMPALA-7660.
The problem with IMPALA-7660 was that urllib.urlopen added the
'context' parameter in 2.7.9, so it isn't present on rhel7, which uses
2.7.5
urllib.urlopen has been deprecated since 2.6 anyways, so the fix is to
switch to using the more current urllib2.
This patch also adds more info to the error message printed by
start-impala-cluster.py when the debug webserver cannot be reached yet
to help with debugging these issues in the future.
Testing:
- Ran full builds on rhel7, rhel6, and ubuntu16.
Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_redaction.py
M tests/run-tests.py
6 files changed, 110 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/11625/3
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 2:
The latest version uses 'requests' instead of 'urllib(2)'. This required a few changes to some other tests (in test_redaction).
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:39:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/990/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 17:08:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3320/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 16 Oct 2018 21:05:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 16 Oct 2018 21:05:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_client_ssl.py
File tests/custom_cluster/test_client_ssl.py:
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_client_ssl.py@116
PS2, Line 116:
> flake8: E261 at least two spaces before inline comment
Done
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py
File tests/custom_cluster/test_redaction.py:
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py@149
PS2, Line 149:
> flake8: E501 line too long (127 > 90 characters)
Done
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py@160
PS2, Line 160:
> flake8: E501 line too long (111 > 90 characters)
Done
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py@167
PS2, Line 167:
> flake8: E501 line too long (114 > 90 characters)
Done
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/run-tests.py
File tests/run-tests.py:
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/run-tests.py@220
PS2, Line 220: s
> flake8: E126 continuation line over-indented for hanging indent
Done
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:45:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Update the commit message, otherwise looks good.
http://gerrit.cloudera.org:8080/#/c/11625/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11625/3//COMMIT_MSG@15
PS3, Line 15: urllib.urlopen has been deprecated since 2.6 anyways, so the fix is to
: switch to using the more current urllib2.
Now that you are using the "requests" library, update this commit message.
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Fri, 12 Oct 2018 21:14:21 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 15 Oct 2018 20:59:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3314/
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 16 Oct 2018 01:15:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3319/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 16 Oct 2018 16:54:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Pooja Nilangekar, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11625
to look at the new patch set (#2).
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
This patch reverses the revert of IMPALA-7660.
The problem with IMPALA-7660 was that urllib.urlopen added the
'context' parameter in 2.7.9, so it isn't present on rhel7, which uses
2.7.5
urllib.urlopen has been deprecated since 2.6 anyways, so the fix is to
switch to using the more current urllib2.
This patch also adds more info to the error message printed by
start-impala-cluster.py when the debug webserver cannot be reached yet
to help with debugging these issues in the future.
Testing:
- Ran a full build on rhel7
Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_redaction.py
M tests/run-tests.py
6 files changed, 106 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/11625/2
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1024/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 11 Oct 2018 17:10:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 5:
gvo failure was unrelated, I filed IMPALA-7716
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 16 Oct 2018 21:04:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Pooja Nilangekar, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11625
to look at the new patch set (#4).
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
This patch reverses the revert of IMPALA-7660.
The problem with IMPALA-7660 was that urllib.urlopen added the
'context' parameter in 2.7.9, so it isn't present on rhel7, which uses
2.7.5
The fix is to switch to using the 'requests' library, which supports
ssl connections on all the platforms Impala is supported on.
This patch also adds more info to the error message printed by
start-impala-cluster.py when the debug webserver cannot be reached yet
to help with debugging these issues in the future.
Testing:
- Ran full builds on rhel7, rhel6, and ubuntu16.
Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_redaction.py
M tests/run-tests.py
6 files changed, 110 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/11625/4
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1025/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 11 Oct 2018 17:17:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3320/
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 17 Oct 2018 00:55:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
This patch reverses the revert of IMPALA-7660.
The problem with IMPALA-7660 was that urllib.urlopen added the
'context' parameter in 2.7.9, so it isn't present on rhel7, which uses
2.7.5
The fix is to switch to using the 'requests' library, which supports
ssl connections on all the platforms Impala is supported on.
This patch also adds more info to the error message printed by
start-impala-cluster.py when the debug webserver cannot be reached yet
to help with debugging these issues in the future.
Testing:
- Ran full builds on rhel7, rhel6, and ubuntu16.
Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Reviewed-on: http://gerrit.cloudera.org:8080/11625
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/thirdparty/squeasel/squeasel.c
M tests/common/impala_cluster.py
M tests/common/impala_service.py
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_redaction.py
M tests/run-tests.py
6 files changed, 110 insertions(+), 52 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 8
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 17 Oct 2018 01:37:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3323/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 17 Oct 2018 01:37:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11625/1/tests/common/impala_service.py
File tests/common/impala_service.py:
http://gerrit.cloudera.org:8080/#/c/11625/1/tests/common/impala_service.py@62
PS1, Line 62: context=context
> https://docs.python.org/2/library/urllib2.html
One option is to use python for our non-SSL stuff and call out to wget or another external utility for the SSL stuff. It adds complication, but I think it should work. We use wget in bootstrap_toolchain.py already.
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 17:14:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3314/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 15 Oct 2018 20:59:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Tue, 16 Oct 2018 20:43:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
carrying forward
http://gerrit.cloudera.org:8080/#/c/11625/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11625/3//COMMIT_MSG@15
PS3, Line 15: The fix is to switch to using the 'requests' library, which supports
: ssl connections on all the platforms Impa
> Now that you are using the "requests" library, update this commit message.
Done
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Mon, 15 Oct 2018 17:47:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 7
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 17 Oct 2018 05:39:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11625/1/tests/common/impala_service.py
File tests/common/impala_service.py:
http://gerrit.cloudera.org:8080/#/c/11625/1/tests/common/impala_service.py@62
PS1, Line 62: context=context
https://docs.python.org/2/library/urllib2.html
It looks like context was added in 2.7.9, so I think we are in trouble for python 2.6 / centos 6. A separate invocation of urllib2.urlopen() without context when not using SSL could avoid problems for dataload and other spots, but the actual SSL tests would still have issues.
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Oct 2018 18:31:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11625/1/tests/common/impala_service.py
File tests/common/impala_service.py:
http://gerrit.cloudera.org:8080/#/c/11625/1/tests/common/impala_service.py@62
PS1, Line 62: context=context
> One option is to use python for our non-SSL stuff and call out to wget or a
I think I'll just switch to using the 'requests' library, which is in infra/python/deps/requirements.txt so it shouldn't suffer from these version issues.
I've run into some additional problems that need to be worked through though.
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 10 Oct 2018 18:37:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver"
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_client_ssl.py
File tests/custom_cluster/test_client_ssl.py:
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_client_ssl.py@116
PS2, Line 116:
flake8: E261 at least two spaces before inline comment
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py
File tests/custom_cluster/test_redaction.py:
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py@149
PS2, Line 149: s
flake8: E501 line too long (127 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py@160
PS2, Line 160:
flake8: E501 line too long (111 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py@167
PS2, Line 167: a
flake8: E501 line too long (114 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/run-tests.py
File tests/run-tests.py:
http://gerrit.cloudera.org:8080/#/c/11625/2/tests/run-tests.py@220
PS2, Line 220: .
flake8: E126 continuation line over-indented for hanging indent
--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:38:45 +0000
Gerrit-HasComments: Yes