You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Uwe Schindler <uw...@thetaphi.de> on 2011/06/19 12:39:40 UTC
RE: svn commit: r1137211 - in /lucene/dev/trunk/lucene: ./ contrib/misc/src/java/org/apache/lucene/index/ src/java/org/apache/lucene/index/ src/test-framework/org/apache/lucene/index/ src/test/org/apache/lucene/index/
Just for curiosity:
> @@ -93,14 +94,16 @@ public class UpgradeIndexMergePolicy ext
> if (oldSegments.isEmpty())
> return null;
>
> - MergeSpecification spec = base.findMergesForOptimize(segmentInfos,
> maxSegmentCount, oldSegments);
> + MergeSpecification spec = base.findMergesForOptimize(segmentInfos,
> + maxSegmentCount, oldSegments);
>
> if (spec != null) {
> // remove all segments that are in merge specification from oldSegments,
> // the resulting set contains all segments that are left over
> // and will be merged to one additional segment:
> for (final OneMerge om : spec.merges) {
> - oldSegments.removeAll(om.segments);
> + for(SegmentInfo info : om.segments) {
> + oldSegments.remove(info);
> + }
> }
> }
This can be simply be optimized by using views:
oldSegments.keySet().removeAll(om.segments);
Uwe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: svn commit: r1137211 - in /lucene/dev/trunk/lucene: ./
contrib/misc/src/java/org/apache/lucene/index/ src/java/org/apache/lucene/index/
src/test-framework/org/apache/lucene/index/ src/test/org/apache/lucene/index/
Posted by Michael McCandless <lu...@mikemccandless.com>.
Ahh yes, good! I'll fix.
Mike McCandless
http://blog.mikemccandless.com
On Sun, Jun 19, 2011 at 6:39 AM, Uwe Schindler <uw...@thetaphi.de> wrote:
> Just for curiosity:
>
>> @@ -93,14 +94,16 @@ public class UpgradeIndexMergePolicy ext
>> if (oldSegments.isEmpty())
>> return null;
>>
>> - MergeSpecification spec = base.findMergesForOptimize(segmentInfos,
>> maxSegmentCount, oldSegments);
>> + MergeSpecification spec = base.findMergesForOptimize(segmentInfos,
>> + maxSegmentCount, oldSegments);
>>
>> if (spec != null) {
>> // remove all segments that are in merge specification from oldSegments,
>> // the resulting set contains all segments that are left over
>> // and will be merged to one additional segment:
>> for (final OneMerge om : spec.merges) {
>> - oldSegments.removeAll(om.segments);
>> + for(SegmentInfo info : om.segments) {
>> + oldSegments.remove(info);
>> + }
>> }
>> }
>
> This can be simply be optimized by using views:
>
> oldSegments.keySet().removeAll(om.segments);
>
> Uwe
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org