[GitHub] [superset] github-code-scanning[bot] commented on a diff in pull request #25343: feat: Adds Sunburst chart migration logic

["github-code-scanning[bot] (via GitHub)" <gi...@apache.org>]

github-code-scanning[bot] commented on code in PR #25343:
URL: https://github.com/apache/superset/pull/25343#discussion_r1330512632


##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts:
##########
@@ -138,7 +138,10 @@
       color: ${theme.colors.grayscale.base}"
      >`,
     `<div style="font-weight: ${theme.typography.weights.bold}">
-      ${node.name}
+      ${(node.name || NULL_STRING)
+        .toString()
+        .replace('<', '&lt;')

Review Comment:
   ## Incomplete string escaping or encoding
   
   This replaces only the first occurrence of '<'.
   
   [Show more details](https://github.com/apache/superset/security/code-scanning/1213)



##########
superset-frontend/plugins/plugin-chart-echarts/src/Sunburst/transformProps.ts:
##########
@@ -138,7 +138,10 @@
       color: ${theme.colors.grayscale.base}"
      >`,
     `<div style="font-weight: ${theme.typography.weights.bold}">
-      ${node.name}
+      ${(node.name || NULL_STRING)
+        .toString()
+        .replace('<', '&lt;')
+        .replace('>', '&gt;')}

Review Comment:
   ## Incomplete string escaping or encoding
   
   This replaces only the first occurrence of '>'.
   
   [Show more details](https://github.com/apache/superset/security/code-scanning/1212)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org