You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2019/01/16 01:02:24 UTC
[GitHub] Jackie-Jiang commented on a change in pull request #3694: Fix the
TableConfig toJSONConfig() method
Jackie-Jiang commented on a change in pull request #3694: Fix the TableConfig toJSONConfig() method
URL: https://github.com/apache/incubator-pinot/pull/3694#discussion_r248120042
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
##########
@@ -608,10 +608,6 @@ public TableConfig build() {
_customConfig.setCustomConfigs(new HashMap<>());
}
- if (_routingConfig == null) {
Review comment:
This one is a nullable variable. Remove it to keep it consistent with the default constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org