You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/02 07:47:10 UTC
[GitHub] [spark] sarutak opened a new pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
sarutak opened a new pull request #31706:
URL: https://github.com/apache/spark/pull/31706
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes a new feature that allows developers to debug test code using JDWP with sbt.
More specifically, this PR introduced the following options for sbt.
* `test.jdwp.enabled`: Flat which controls JDWP enabled or disabled for tests
* `test.jdwp.address`: An option which corresponds to `address` option in JDWP
* `test.jdwp.suspend`: An option which corresponds to `suspend` option in JDWP
* `test.jdwp.server`: An option which corresponds to `server` option in JDWP
We can use these options like `build/sbt -Dtest.jdwp.enabled=true -Dtest.jdwp.address=localhost:9876 -Dtest.jdwp.suspend=y -Dtest.jdwp.server=y` and can be used for both JUnit tests and ScalaTest tests.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
It's useful to debug test code.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
I confirmed the following things.
* `test.jdwp.enabled` can switch JDWP enabled/disabled
* `test.jdwp.address` can change address and port.
* `test.jdwp.suspend` can change the behavior that the target debugee suspends or not.
* `test.jdwp.server` can change the behavior that the JDWP debugger run as a server or client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789412136
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40265/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31706:
URL: https://github.com/apache/spark/pull/31706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789408797
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40265/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789412127
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40265/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788734578
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40218/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789738405
> I think it's OK to just add for SBT.
I usually use SBT so it's OK for me but @dongjoon-hyun , do you think it's OK even if this change doesn't contain this feature for Maven?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789396460
**[Test build #135683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135683/testReport)** for PR 31706 at commit [`d0461ee`](https://github.com/apache/spark/commit/d0461ee5d166c0031c2964c6f55312503566184a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789412136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788725800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788734578
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40218/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788890202
@dongjoon-hyun It's just I don't know how to do the same thing for Maven for now. I'll add the same feature after I find the way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788890202
@dongjoon-hyun It's just because I don't know how to do the same thing for Maven for now. I'll add the same feature after I find the way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789385803
I think it's OK to just add for SBT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789906677
Merged to master. Thank you, @sarutak and @srowen .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789382397
@srowen
Thanks for the advice. Now we can switch this feature with `-Pjdwp-test-debug` both for `sbt` and `Maven`.
@dongjoon-hyun
For Maven, `scalatest-maven-plugin` supports JDWP debug but it's a little bit unuseful (suspended for each sub-modules even though a sub-module doesn't contain suites to run) so I've added `test.debug.suite` property only for Maven.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789453952
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135683/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789396460
**[Test build #135683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135683/testReport)** for PR 31706 at commit [`d0461ee`](https://github.com/apache/spark/commit/d0461ee5d166c0031c2964c6f55312503566184a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788820467
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135638/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788967119
It would just be a new profile that modifies some test runner settings or something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788696841
**[Test build #135638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135638/testReport)** for PR 31706 at commit [`a609cd9`](https://github.com/apache/spark/commit/a609cd91013f99431a6e1487e63b7200c0753d9b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788819130
**[Test build #135638 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135638/testReport)** for PR 31706 at commit [`a609cd9`](https://github.com/apache/spark/commit/a609cd91013f99431a6e1487e63b7200c0753d9b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-789450047
**[Test build #135683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135683/testReport)** for PR 31706 at commit [`d0461ee`](https://github.com/apache/spark/commit/d0461ee5d166c0031c2964c6f55312503566184a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788820467
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135638/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31706: [SPARK-34590][TESTS] Allow JDWP debug for tests with sbt
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31706:
URL: https://github.com/apache/spark/pull/31706#issuecomment-788696841
**[Test build #135638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135638/testReport)** for PR 31706 at commit [`a609cd9`](https://github.com/apache/spark/commit/a609cd91013f99431a6e1487e63b7200c0753d9b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org