You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/08/11 19:08:42 UTC
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18841
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
IMPALA-10213: Add test for local vs remote scheduling
Impala already supports locality-aware scheduling with Ozone because it
returns location data on partitions. That data doesn't include specific
storage ids in getStorageIds, so we skip a warning that will always
trigger on Ozone.
Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for
local development. HDFS translates localhost to 127.0.0.1 for host names
in its location data, which Impala will identify as colocated with
executors in the dev environment. Ozone doesn't, and the default Impala
hostname is the machine hostname - not localhost - so without this
change all HDFS access in the minicluster is local but all Ozone access
is remote.
Adds a test to verify local vs remote assignment by using custom
clusters with hostnames that either do or don't match storage hostnames.
Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
---
M be/src/runtime/io/disk-io-mgr.cc
M be/src/scheduling/executor-group.cc
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/common/skip.py
A tests/custom_cluster/test_scheduler_locality.py
M tests/metadata/test_stats_extrapolation.py
6 files changed, 71 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18841/1
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
IMPALA-10213: Add test for local vs remote scheduling
Impala already supports locality-aware scheduling with Ozone because it
returns location data on partitions. That data doesn't include specific
storage ids in getStorageIds, so we skip a warning that will always
trigger on Ozone.
Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for
local development. HDFS translates localhost to 127.0.0.1 for host names
in its location data, which Impala will identify as colocated with
executors in the dev environment. Ozone doesn't, and the default Impala
hostname is the machine hostname - not localhost - so without this
change all HDFS access in the minicluster is local but all Ozone access
is remote.
Adds a test to verify local vs remote assignment by using custom
clusters with hostnames that either do or don't match storage hostnames.
Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Reviewed-on: http://gerrit.cloudera.org:8080/18841
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M be/src/runtime/io/disk-io-mgr.cc
M be/src/scheduling/executor-group.cc
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/common/skip.py
A tests/custom_cluster/test_scheduler_locality.py
M tests/metadata/test_stats_extrapolation.py
6 files changed, 65 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18841/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18841/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1385
PS7, Line 1385: if (fsType != FileSystemUtil.FsType.OZONE) { ++numScanRangesNoDiskIds_; }
> Format to multiple lines
I was following the single line conditional from https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536 originally. However coding style for Java is undefined, so I'll defer to you on it.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 18:47:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18841/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18841/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1384
PS4, Line 1384: // Skip Ozone; it returns NULL storageIds and users can't do anything about it.
Created a ticket to revert this once Ozone returns useful storage IDs: https://issues.apache.org/jira/browse/IMPALA-11541
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 18:46:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 03:17:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11249/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 23:41:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18841
to look at the new patch set (#5).
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
IMPALA-10213: Add test for local vs remote scheduling
Impala already supports locality-aware scheduling with Ozone because it
returns location data on partitions. That data doesn't include specific
storage ids in getStorageIds, so we skip a warning that will always
trigger on Ozone.
Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for
local development. HDFS translates localhost to 127.0.0.1 for host names
in its location data, which Impala will identify as colocated with
executors in the dev environment. Ozone doesn't, and the default Impala
hostname is the machine hostname - not localhost - so without this
change all HDFS access in the minicluster is local but all Ozone access
is remote.
Adds a test to verify local vs remote assignment by using custom
clusters with hostnames that either do or don't match storage hostnames.
Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
---
M be/src/runtime/io/disk-io-mgr.cc
M be/src/scheduling/executor-group.cc
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
A tests/common/network.py
M tests/common/skip.py
A tests/custom_cluster/test_scheduler_locality.py
M tests/metadata/test_stats_extrapolation.py
7 files changed, 93 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18841/5
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18841/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18841/7/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1385
PS7, Line 1385: if (fsType != FileSystemUtil.FsType.OZONE) { ++numScanRangesNoDiskIds_; }
Format to multiple lines
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 18:45:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18841/2/tests/custom_cluster/test_scheduler_locality.py
File tests/custom_cluster/test_scheduler_locality.py:
http://gerrit.cloudera.org:8080/#/c/18841/2/tests/custom_cluster/test_scheduler_locality.py@27
PS2, Line 27: def get_external_ip():
This makes sense to move into the class definition.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 22:46:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 3:
Latest change was very minor refactoring, so I'd appreciate review before I kick off another Jenkins run.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 17:35:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11247/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 23:39:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18841
to look at the new patch set (#2).
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
IMPALA-10213: Add test for local vs remote scheduling
Impala already supports locality-aware scheduling with Ozone because it
returns location data on partitions. That data doesn't include specific
storage ids in getStorageIds, so we skip a warning that will always
trigger on Ozone.
Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for
local development. HDFS translates localhost to 127.0.0.1 for host names
in its location data, which Impala will identify as colocated with
executors in the dev environment. Ozone doesn't, and the default Impala
hostname is the machine hostname - not localhost - so without this
change all HDFS access in the minicluster is local but all Ozone access
is remote.
Adds a test to verify local vs remote assignment by using custom
clusters with hostnames that either do or don't match storage hostnames.
Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
---
M be/src/runtime/io/disk-io-mgr.cc
M be/src/scheduling/executor-group.cc
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/common/skip.py
A tests/custom_cluster/test_scheduler_locality.py
M tests/metadata/test_stats_extrapolation.py
6 files changed, 73 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18841/2
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11194/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Aug 2022 22:12:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18841
to look at the new patch set (#8).
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
IMPALA-10213: Add test for local vs remote scheduling
Impala already supports locality-aware scheduling with Ozone because it
returns location data on partitions. That data doesn't include specific
storage ids in getStorageIds, so we skip a warning that will always
trigger on Ozone.
Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for
local development. HDFS translates localhost to 127.0.0.1 for host names
in its location data, which Impala will identify as colocated with
executors in the dev environment. Ozone doesn't, and the default Impala
hostname is the machine hostname - not localhost - so without this
change all HDFS access in the minicluster is local but all Ozone access
is remote.
Adds a test to verify local vs remote assignment by using custom
clusters with hostnames that either do or don't match storage hostnames.
Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
---
M be/src/runtime/io/disk-io-mgr.cc
M be/src/scheduling/executor-group.cc
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/common/skip.py
A tests/custom_cluster/test_scheduler_locality.py
M tests/metadata/test_stats_extrapolation.py
6 files changed, 65 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18841/8
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18841
to look at the new patch set (#6).
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
IMPALA-10213: Add test for local vs remote scheduling
Impala already supports locality-aware scheduling with Ozone because it
returns location data on partitions. That data doesn't include specific
storage ids in getStorageIds, so we skip a warning that will always
trigger on Ozone.
Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for
local development. HDFS translates localhost to 127.0.0.1 for host names
in its location data, which Impala will identify as colocated with
executors in the dev environment. Ozone doesn't, and the default Impala
hostname is the machine hostname - not localhost - so without this
change all HDFS access in the minicluster is local but all Ozone access
is remote.
Adds a test to verify local vs remote assignment by using custom
clusters with hostnames that either do or don't match storage hostnames.
Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
---
M be/src/runtime/io/disk-io-mgr.cc
M be/src/scheduling/executor-group.cc
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
A tests/common/network.py
M tests/common/skip.py
A tests/custom_cluster/test_scheduler_locality.py
M tests/metadata/test_stats_extrapolation.py
7 files changed, 94 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18841/6
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py
File tests/custom_cluster/test_scheduler_locality.py:
http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@26
PS1, Line 26: def get_external_ip():
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@32
PS1, Line 32: LOCAL_ASSIGNMENTS_METRIC = "simple-scheduler.local-assignments.total"
flake8: E305 expected 2 blank lines after class or function definition, found 1
http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@44
PS1, Line 44: i
flake8: E126 continuation line over-indented for hanging indent
http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@51
PS1, Line 51: T
flake8: E126 continuation line over-indented for hanging indent
http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@55
PS1, Line 55: i
flake8: E126 continuation line over-indented for hanging indent
http://gerrit.cloudera.org:8080/#/c/18841/1/tests/custom_cluster/test_scheduler_locality.py@55
PS1, Line 55: +
flake8: E226 missing whitespace around arithmetic operator
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:09:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8445/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 16:38:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18841
to look at the new patch set (#4).
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
IMPALA-10213: Add test for local vs remote scheduling
Impala already supports locality-aware scheduling with Ozone because it
returns location data on partitions. That data doesn't include specific
storage ids in getStorageIds, so we skip a warning that will always
trigger on Ozone.
Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for
local development. HDFS translates localhost to 127.0.0.1 for host names
in its location data, which Impala will identify as colocated with
executors in the dev environment. Ozone doesn't, and the default Impala
hostname is the machine hostname - not localhost - so without this
change all HDFS access in the minicluster is local but all Ozone access
is remote.
Adds a test to verify local vs remote assignment by using custom
clusters with hostnames that either do or don't match storage hostnames.
Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
---
M be/src/runtime/io/disk-io-mgr.cc
M be/src/scheduling/executor-group.cc
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/common/skip.py
A tests/custom_cluster/test_scheduler_locality.py
M tests/metadata/test_stats_extrapolation.py
6 files changed, 74 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18841/4
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Kurt Deschler (Code Review)" <ge...@cloudera.org>.
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18841/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:
http://gerrit.cloudera.org:8080/#/c/18841/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1385
PS3, Line 1385: if (fsType != FileSystemUtil.FsType.OZONE) ++numScanRangesNoDiskIds_;
Add {}
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Aug 2022 17:59:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18841/5/tests/common/network.py
File tests/common/network.py:
http://gerrit.cloudera.org:8080/#/c/18841/5/tests/common/network.py@24
PS5, Line 24: def get_external_ip():
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 23:19:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 8: Code-Review+2
This makes sense to me
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Sep 2022 17:12:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11303/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 19:08:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18841
to look at the new patch set (#3).
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
IMPALA-10213: Add test for local vs remote scheduling
Impala already supports locality-aware scheduling with Ozone because it
returns location data on partitions. That data doesn't include specific
storage ids in getStorageIds, so we skip a warning that will always
trigger on Ozone.
Updates Ozone to add implicit rules mapping localhost -> 127.0.0.1 for
local development. HDFS translates localhost to 127.0.0.1 for host names
in its location data, which Impala will identify as colocated with
executors in the dev environment. Ozone doesn't, and the default Impala
hostname is the machine hostname - not localhost - so without this
change all HDFS access in the minicluster is local but all Ozone access
is remote.
Adds a test to verify local vs remote assignment by using custom
clusters with hostnames that either do or don't match storage hostnames.
Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
---
M be/src/runtime/io/disk-io-mgr.cc
M be/src/scheduling/executor-group.cc
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M tests/common/skip.py
A tests/custom_cluster/test_scheduler_locality.py
M tests/metadata/test_stats_extrapolation.py
6 files changed, 72 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/18841/3
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 21:37:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11149/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 19:29:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 22:42:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8512/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 17:57:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8535/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 22:31:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11160/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 23:24:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10213: Add test for local vs remote scheduling
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18841 )
Change subject: IMPALA-10213: Add test for local vs remote scheduling
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11154/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e5606528404c3d4fd164c03dec8315345be5f6d
Gerrit-Change-Number: 18841
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 16:28:57 +0000
Gerrit-HasComments: No