You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2023/08/18 20:37:00 UTC

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20380


Change subject: [tools] Add Dev Container support for Impala development.
......................................................................

[tools] Add Dev Container support for Impala development.

Currently only VS Code is supported since IntelliJ/CLion support for
Dev Container is still beta at the time of this writing.

To use it, simply open Impala source code.

$ git clone https://github.com/apache/impala.git
$ cd impala
$ code .

The bootstrap_development.sh will be automatically executed post Docker
container creation and all necesary extensions for IDE-like experience
will be automatically installed. For C++, it uses clangd that uses
compilation database instead of the Microsoft C++ extension since it
works better with Clang related tools.

Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
---
A .devcontainer/Dockerfile
A .devcontainer/devcontainer.json
2 files changed, 32 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/20380/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................

[tools] Add Dev Container support for Impala development.

Currently only VS Code is supported since IntelliJ/CLion support for
Dev Container is still beta at the time of this writing.

To use it, simply open Impala source code.

$ git clone https://github.com/apache/impala.git
$ cd impala
$ code .

The bootstrap_development.sh will be automatically executed post Docker
container creation and all necessary extensions for IDE-like experience
will be automatically installed. For C++, it will use clangd that uses
compilation database instead of the Microsoft C++ extension since it
works better with Clang related tools.

Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
---
A .devcontainer/Dockerfile
A .devcontainer/devcontainer.json
2 files changed, 32 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/20380/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................

[tools] Add Dev Container support for Impala development.

Currently only VS Code is supported since IntelliJ/CLion support for
Dev Container is still beta at the time of this writing.

To use it, simply open Impala source code.

$ git clone https://github.com/apache/impala.git
$ cd impala
$ code .

The bootstrap_development.sh will be automatically executed post Docker
container creation and all necessary extensions for IDE-like experience
will be automatically installed. For C++, it will use clangd that uses
compilation database instead of the Microsoft C++ extension since it
works better with Clang related tools.

Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Reviewed-on: http://gerrit.cloudera.org:8080/20380
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
A .devcontainer/Dockerfile
A .devcontainer/devcontainer.json
M bin/rat_exclude_files.txt
3 files changed, 33 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Quanlong Huang: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20380/1/.devcontainer/Dockerfile
File .devcontainer/Dockerfile:

http://gerrit.cloudera.org:8080/#/c/20380/1/.devcontainer/Dockerfile@1
PS1, Line 1: FROM ubuntu:18.04
Could this be done on 20.04? That's where we're moving most testing.



-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Aug 2023 21:15:35 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 1:

(1 comment)

Great to see you again, Fredy :)

http://gerrit.cloudera.org:8080/#/c/20380/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20380/1//COMMIT_MSG@19
PS1, Line 19: necesary
nit: typo 'necessary'



-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Aug 2023 22:04:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9626/


-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 12:04:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 4: Verified+1

> Patch Set 4: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9626/

The failure is unrelated: IMPALA-12266
Merging this.


-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 12:30:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/13782/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 1
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Aug 2023 20:58:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/13805/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Aug 2023 15:59:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................

[tools] Add Dev Container support for Impala development.

Currently only VS Code is supported since IntelliJ/CLion support for
Dev Container is still beta at the time of this writing.

To use it, simply open Impala source code.

$ git clone https://github.com/apache/impala.git
$ cd impala
$ code .

The bootstrap_development.sh will be automatically executed post Docker
container creation and all necessary extensions for IDE-like experience
will be automatically installed. For C++, it will use clangd that uses
compilation database instead of the Microsoft C++ extension since it
works better with Clang related tools.

Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
---
A .devcontainer/Dockerfile
A .devcontainer/devcontainer.json
M bin/rat_exclude_files.txt
3 files changed, 33 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/20380/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 3: Code-Review+2

LGTM. Welcome back to the community, Fredy! We really miss you.

BTW, it'd be nice if you could also update the wiki about this:
https://cwiki.apache.org/confluence/display/IMPALA/Impala+Development+Environment+inside+Docker


-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 07:47:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9626/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 07:47:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 5:

> Patch Set 3: Code-Review+2
> 
> LGTM. Welcome back to the community, Fredy! We really miss you.
> 
> BTW, it'd be nice if you could also update the wiki about this:
> https://cwiki.apache.org/confluence/display/IMPALA/Impala+Development+Environment+inside+Docker

Thanks Quanlong for the LGTM :) Done. Updated the wiki.


-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 5
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 16:00:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20380/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20380/1//COMMIT_MSG@19
PS1, Line 19: necessar
> Done
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Aug 2023 20:40:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 4
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 07:47:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )

Change subject: [tools] Add Dev Container support for Impala development.
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13807/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5
Gerrit-Change-Number: 20380
Gerrit-PatchSet: 3
Gerrit-Owner: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Fredy Wijaya <fr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Aug 2023 17:23:26 +0000
Gerrit-HasComments: No