You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/10/15 04:19:45 UTC

[GitHub] [beam] lostluck commented on a change in pull request #13123: [BEAM-10959] Fix circle buffer.

lostluck commented on a change in pull request #13123:
URL: https://github.com/apache/beam/pull/13123#discussion_r505154619



##########
File path: sdks/go/pkg/beam/core/runtime/harness/harness.go
##########
@@ -158,6 +158,60 @@ func Main(ctx context.Context, loggingEndpoint, controlEndpoint string) error {
 type bundleDescriptorID string
 type instructionID string
 
+const circleBufferCap = 1000
+
+// circleBuffer is an ordered eviction buffer
+type circleBuffer struct {
+	// a plan that's either about to start or has finished recently

Review comment:
       Ah! good catch. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org