You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/27 16:38:10 UTC
[GitHub] [flink] zjuwangg opened a new pull request #10709:
[FLINK-13437][test] Add Hive SQL E2E test
zjuwangg opened a new pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709
## What is the purpose of the change
Set up a docker-based yarn-cluster and hive service using the new java based test runtime framework, add HiveConnectorITCase to cover data read/write function, including:
1. hive data writen by Hive, read by Flink.
2. hive data writen by Flink, read by Hive.
3. read/write to a non-partition table.
4. multi-format for read and write, cover textfile/orc/parquet
Based on this PR, we can add more test such as function/view in further more.
## Brief change log
- 3488ec6 Add e2e test for hive data connector using docker based environment
- 2f8b127 refactor hive e2e test using new java-based test framework
- 76c6f08 add muliti format test and all data types test case
- 31cc4b7 remote e2e bash test
## Verifying this change
- *Added integration tests for end-to-end deployment *
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#discussion_r365148227
##########
File path: flink-end-to-end-tests/flink-connector-hive-test/src/main/java/org/apache/flink/tests/util/hive/YarnClusterFlinkResource.java
##########
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hive;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.GlobalConfiguration;
+import org.apache.flink.configuration.UnmodifiableConfiguration;
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.JobController;
+import org.apache.flink.tests.util.flink.JobSubmission;
+
+import org.apache.commons.lang3.StringUtils;
+import org.junit.Assert;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.UUID;
+import java.util.concurrent.CompletableFuture;
+import java.util.stream.Collectors;
+
+/**
+ * YarnClusterFlinkResource use the {@link YarnClusterAndHiveResource} as the yarn cluster to submit flink job in
+ * per-job mode.
+ */
+public class YarnClusterFlinkResource implements FlinkResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(YarnClusterFlinkResource.class);
+ private final YarnClusterAndHiveResource yarnCluster;
+ private final TemporaryFolder temporaryFolder = new TemporaryFolder();
+ private final Path originalFlinkDir;
+ private boolean deployFlinkToRemote = false;
+ public final String remoteFlinkDir = "/home/hadoop-user/flink";
+ Path localFlinkDir;
+ private Configuration defaultConfig;
+ private Path conf;
+
+ public YarnClusterFlinkResource(YarnClusterAndHiveResource yarnCluster) {
+ this.yarnCluster = yarnCluster;
+ final String distDirProperty = System.getProperty("distDir");
+ if (distDirProperty == null) {
+ Assert.fail("The distDir property was not set. You can set it when running maven via -DdistDir=<path> .");
+ }
+ originalFlinkDir = Paths.get(distDirProperty);
+ }
+
+ @Override
+ public void addConfiguration(Configuration config) throws IOException {
+ final Configuration mergedConfig = new Configuration();
+ mergedConfig.addAll(defaultConfig);
+ mergedConfig.addAll(config);
+
+ final List<String> configurationLines = mergedConfig.toMap().entrySet().stream()
+ .map(entry -> entry.getKey() + ": " + entry.getValue())
+ .collect(Collectors.toList());
+
+ Files.write(conf.resolve("flink-conf.yaml"), configurationLines);
+ }
+
+ @Override
+ public ClusterController startCluster(int numTaskManagers) throws IOException {
+ if (!deployFlinkToRemote) {
+ yarnCluster.copyLocalFileToYarnMaster(localFlinkDir.toAbsolutePath().toString(), remoteFlinkDir);
+ deployFlinkToRemote = true;
+ }
+ return new YarnClusterController(this, yarnCluster, numTaskManagers);
+ }
+
+ @Override
+ public void before() throws Exception {
+ temporaryFolder.create();
+ localFlinkDir = temporaryFolder.newFolder().toPath();
+
+ LOG.info("Copying distribution to {}.", localFlinkDir);
+ TestUtils.copyDirectory(originalFlinkDir, localFlinkDir);
Review comment:
Why do we need to copy the dist dir?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#discussion_r365160531
##########
File path: flink-end-to-end-tests/flink-connector-hive-test/src/test/java/org/apache/flink/connectors/hive/HiveConnectorITCase.java
##########
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.JobManagerOptions;
+import org.apache.flink.configuration.ResourceManagerOptions;
+import org.apache.flink.connectors.hive.tests.HiveReadWriteDataExample;
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.categories.TravisGroup1;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.JobSubmission;
+import org.apache.flink.tests.util.hive.YarnClusterAndHiveDockerResource;
+import org.apache.flink.tests.util.hive.YarnClusterAndHiveResource;
+import org.apache.flink.tests.util.hive.YarnClusterFlinkResource;
+import org.apache.flink.util.TestLogger;
+
+import org.junit.Assert;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.nio.file.Path;
+
+/**
+ * A test case used to test hive connector, hive meta and other function in an end to end way.
+ */
+@Category(value = {TravisGroup1.class})
+public class HiveConnectorITCase extends TestLogger {
+ private static String hiveVersion = "2.3.6";
+ private static String hadoopVersion = "2.8.5";
+ private static Path testJarPath;
+
+ @ClassRule
+ public static YarnClusterAndHiveResource clusterAndHiveResource =
+ new YarnClusterAndHiveDockerResource(hiveVersion, hadoopVersion);
+
+ @ClassRule
+ public static YarnClusterFlinkResource flinkResource =
+ new YarnClusterFlinkResource(clusterAndHiveResource);
+
+ @BeforeClass
+ public static void beforeClass() throws Exception {
+ Configuration configuration = new Configuration();
+ configuration.setLong(JobManagerOptions.SLOT_REQUEST_TIMEOUT, 120000);
+ configuration.setInteger(ResourceManagerOptions.CONTAINERIZED_HEAP_CUTOFF_MIN, 100);
+ flinkResource.addConfiguration(configuration);
+ testJarPath = TestUtils.getResourceJar("/testHive.jar");
+ }
+
+ /**
+ * E2e test to test basic write/read data, including :
+ * 1. hive data writen by Hive, read by Flink.
+ * 2. hive data writen by Flink, read by Hive.
+ * 3. read/write to a non-partition table.
+ * 4. multi-format for read and write, cover textfile/orc/parquet
+ * @throws Exception
+ */
+ @Test
+ public void testSimpleReadWriteHiveTable() throws Exception {
+ clusterAndHiveResource.execHiveSql("CREATE TABLE non_partition_table ( " +
+ "a INT, b INT, c STRING, d BIGINT, e DOUBLE) " +
+ "row format delimited fields terminated by ','");
+ String localPath = getClass().getResource("/test-data/non_partition_table.txt").getFile();
+ clusterAndHiveResource.copyLocalFileToHiveGateWay(localPath,
+ "/tmp/test-data/non_partition_table.txt");
+ clusterAndHiveResource.execHiveSql("load data local inpath '/tmp/test-data/non_partition_table.txt' " +
+ "into table non_partition_table");
+ String expectedResults = clusterAndHiveResource.execHiveSql("select * from non_partition_table");
+ // Read and write textfile/orc/parquet format
+ String[] formats = new String[] {"textfile", "orc", "parquet"};
+ for (String format : formats) {
+ String sourceTable = String.format("%s_non_partition_table", format);
+ String destTable = String.format("dest_%s_non_partition_table", format);
+ clusterAndHiveResource.execHiveSql(
+ String.format("create table %s " +
+ "STORED AS %s " +
+ "as select * from non_partition_table", sourceTable, format.toUpperCase()));
+ clusterAndHiveResource.execHiveSql(
+ String.format("create table %s like %s", destTable, sourceTable));
+ try (final ClusterController clusterController = flinkResource.startCluster(1)) {
+ JobSubmission.JobSubmissionBuilder jobSubmissionBuilder = new JobSubmission.JobSubmissionBuilder(
+ testJarPath);
+ jobSubmissionBuilder.setParallelism(1)
+ .addOption("-ys", "1")
+ .addOption("-ytm", "1000")
+ .addOption("-yjm", "1000")
+ .addOption("-c", HiveReadWriteDataExample.class.getCanonicalName())
+ .addArgument("--hiveVersion", hiveVersion)
+ .addArgument("--sourceTable", sourceTable)
+ .addArgument("--targetTable", destTable);
+ YarnClusterFlinkResource.YarnClusterJobController jobController =
+ (YarnClusterFlinkResource.YarnClusterJobController) clusterController.submitJob(
+ jobSubmissionBuilder.build());
+ log.info(jobController.fetchExecuteLog());
+ }
+ String actualResults = clusterAndHiveResource.execHiveSql(String.format("select * from %s", destTable));
+ Assert.assertEquals(expectedResults, actualResults);
+ }
+ }
+
+ /**
+ * Test all dataTypes now we supported.
+ * @throws Exception
+ */
+ @Test
+ public void testComplexReadWriteHiveTable() throws Exception {
+ clusterAndHiveResource.execHiveSql(
+ "CREATE TABLE `all_types_table`(\n" +
+ " `tinyintcol` tinyint,\n" +
+ " `samllinttypecol` smallint,\n" +
+ " `intcol` int,\n" +
+ " `bigintcol` bigint,\n" +
+ " `floatcol` float,\n" +
+ " `doublecol` double,\n" +
+ " `decimalcol` decimal(10,0),\n" +
+ " `decimalprecisioncol` decimal(38,10),\n" +
+ " `timestampcol` timestamp,\n" +
+ " `datecol` date,\n" +
+ " `varcharcol` varchar(20),\n" +
+ " `charcol` char(10),\n" +
+ " `stringcol` string,\n" +
+ " `booleancol` boolean,\n" +
+ " `binarycol` binary,\n" +
+ " `arraycol` array<struct<a:int,t:string>>,\n" +
+ " `mapcol` map<int,array<string>>,\n" +
+ " `structcol` struct<a:tinyint,b:char(10),m:map<int,string>>)\n" +
+ "COMMENT 'all datatypes table'\n" +
+ "ROW FORMAT DELIMITED FIELDS TERMINATED BY ';' COLLECTION ITEMS TERMINATED BY ',' MAP KEYS TERMINATED BY ':'");
+ String localPath = getClass().getResource("/test-data/all_types_table.txt").getFile();
+ clusterAndHiveResource.copyLocalFileToHiveGateWay(localPath,
+ "/tmp/test-data/all_types_table.txt");
+ clusterAndHiveResource.execHiveSql("load data local inpath '/tmp/test-data/all_types_table.txt' " +
+ "into table all_types_table");
+ clusterAndHiveResource.execHiveSql("CREATE TABLE dest_all_types_table like all_types_table");
+ try (final ClusterController clusterController = flinkResource.startCluster(1)) {
+ JobSubmission.JobSubmissionBuilder jobSubmissionBuilder = new JobSubmission.JobSubmissionBuilder(testJarPath);
+ jobSubmissionBuilder.setParallelism(1)
+ .addOption("-ys", "1")
+ .addOption("-ytm", "1000")
+ .addOption("-yjm", "1000")
+ .addOption("-c", HiveReadWriteDataExample.class.getCanonicalName())
+ .addArgument("--hiveVersion", hiveVersion)
+ .addArgument("--sourceTable", "all_types_table")
+ .addArgument("--targetTable", "dest_all_types_table");
Review comment:
I think the job submission code is the same for the 2 test cases. Can we reuse it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zjuwangg commented on issue #10709: [FLINK-13437][test] Add
Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-572861002
@bowenli86 @JingsongLi Do you guys have time to have a basic look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/142473285",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150762354",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "e580f035522a9ccf395fa571e668dfef834f2695",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e580f035522a9ccf395fa571e668dfef834f2695",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 889c2d9112462f22e6e8f4af9ba85b07b5f3c424 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150762354) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657)
* e580f035522a9ccf395fa571e668dfef834f2695 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10709: [FLINK-13437][test] Add
Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569303649
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 31cc4b771858ddf31a5cc19f2d3257b38f944825 (Fri Dec 27 16:40:35 UTC 2019)
**Warnings:**
* **3 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/142473285",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31cc4b771858ddf31a5cc19f2d3257b38f944825 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142473285) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962)
* 889c2d9112462f22e6e8f4af9ba85b07b5f3c424 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10709: [FLINK-13437][test]
Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-591767034
Thanks @zjuwangg for your great work! I will continue to working on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/142473285",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150762354",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "e580f035522a9ccf395fa571e668dfef834f2695",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5660",
"triggerID" : "e580f035522a9ccf395fa571e668dfef834f2695",
"triggerType" : "PUSH"
}, {
"hash" : "e580f035522a9ccf395fa571e668dfef834f2695",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150771067",
"triggerID" : "e580f035522a9ccf395fa571e668dfef834f2695",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e580f035522a9ccf395fa571e668dfef834f2695 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150771067) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5660)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/142473285",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150762354",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31cc4b771858ddf31a5cc19f2d3257b38f944825 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142473285) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962)
* 889c2d9112462f22e6e8f4af9ba85b07b5f3c424 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150762354) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/142473285",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150762354",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "e580f035522a9ccf395fa571e668dfef834f2695",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5660",
"triggerID" : "e580f035522a9ccf395fa571e668dfef834f2695",
"triggerType" : "PUSH"
}, {
"hash" : "e580f035522a9ccf395fa571e668dfef834f2695",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150771067",
"triggerID" : "e580f035522a9ccf395fa571e668dfef834f2695",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 889c2d9112462f22e6e8f4af9ba85b07b5f3c424 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150762354) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657)
* e580f035522a9ccf395fa571e668dfef834f2695 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150771067) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5660)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#discussion_r365143456
##########
File path: flink-end-to-end-tests/flink-connector-hive-test/src/main/java/org/apache/flink/tests/util/hive/YarnClusterFlinkResource.java
##########
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hive;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.GlobalConfiguration;
+import org.apache.flink.configuration.UnmodifiableConfiguration;
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.JobController;
+import org.apache.flink.tests.util.flink.JobSubmission;
+
+import org.apache.commons.lang3.StringUtils;
+import org.junit.Assert;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.UUID;
+import java.util.concurrent.CompletableFuture;
+import java.util.stream.Collectors;
+
+/**
+ * YarnClusterFlinkResource use the {@link YarnClusterAndHiveResource} as the yarn cluster to submit flink job in
+ * per-job mode.
+ */
+public class YarnClusterFlinkResource implements FlinkResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(YarnClusterFlinkResource.class);
+ private final YarnClusterAndHiveResource yarnCluster;
+ private final TemporaryFolder temporaryFolder = new TemporaryFolder();
+ private final Path originalFlinkDir;
+ private boolean deployFlinkToRemote = false;
+ public final String remoteFlinkDir = "/home/hadoop-user/flink";
+ Path localFlinkDir;
+ private Configuration defaultConfig;
+ private Path conf;
+
+ public YarnClusterFlinkResource(YarnClusterAndHiveResource yarnCluster) {
+ this.yarnCluster = yarnCluster;
+ final String distDirProperty = System.getProperty("distDir");
+ if (distDirProperty == null) {
+ Assert.fail("The distDir property was not set. You can set it when running maven via -DdistDir=<path> .");
+ }
+ originalFlinkDir = Paths.get(distDirProperty);
+ }
+
+ @Override
+ public void addConfiguration(Configuration config) throws IOException {
+ final Configuration mergedConfig = new Configuration();
+ mergedConfig.addAll(defaultConfig);
+ mergedConfig.addAll(config);
+
+ final List<String> configurationLines = mergedConfig.toMap().entrySet().stream()
+ .map(entry -> entry.getKey() + ": " + entry.getValue())
+ .collect(Collectors.toList());
+
+ Files.write(conf.resolve("flink-conf.yaml"), configurationLines);
+ }
+
+ @Override
+ public ClusterController startCluster(int numTaskManagers) throws IOException {
+ if (!deployFlinkToRemote) {
+ yarnCluster.copyLocalFileToYarnMaster(localFlinkDir.toAbsolutePath().toString(), remoteFlinkDir);
+ deployFlinkToRemote = true;
+ }
+ return new YarnClusterController(this, yarnCluster, numTaskManagers);
+ }
+
+ @Override
+ public void before() throws Exception {
+ temporaryFolder.create();
+ localFlinkDir = temporaryFolder.newFolder().toPath();
+
+ LOG.info("Copying distribution to {}.", localFlinkDir);
+ TestUtils.copyDirectory(originalFlinkDir, localFlinkDir);
+ conf = localFlinkDir.resolve("conf");
+ defaultConfig = new UnmodifiableConfiguration(GlobalConfiguration.loadConfiguration(conf.toAbsolutePath().toString()));
+ }
+
+ @Override
+ public void afterTestSuccess() {
+ temporaryFolder.delete();
+ }
+
+ @Override
+ public void afterTestFailure() {
+ temporaryFolder.delete();
+ }
+
+ /**
+ * YarnClusterController used to submit job in yarn per-job mode.
+ */
+ private static class YarnClusterController implements ClusterController {
+ private final YarnClusterFlinkResource flinkResource;
+ private final YarnClusterAndHiveResource yarnClusterAndHiveResource;
+ private final int numTaskManagers;
+
+ public YarnClusterController(
+ YarnClusterFlinkResource flinkResource,
+ YarnClusterAndHiveResource yarnClusterAndHiveResource,
+ int numTaskManagers) {
+ this.flinkResource = flinkResource;
+ this.yarnClusterAndHiveResource = yarnClusterAndHiveResource;
+ this.numTaskManagers = numTaskManagers;
+ }
+
+ /**
+ * Submits the given job to the cluster.
+ *
+ * @param job job to submit
+ * @return JobController for the submitted job
+ * @throws IOException
+ */
+ @Override
+ public JobController submitJob(JobSubmission job) throws IOException {
+ Path jobJarPath = job.getJar();
+ String targetPath = String.format("/tmp/%s-%s", UUID.randomUUID(), jobJarPath.toFile().getName());
+ yarnClusterAndHiveResource.copyLocalFileToYarnMaster(
+ jobJarPath.toAbsolutePath().toString(), targetPath);
+ List<String> commands = new ArrayList<>();
+ commands.add("docker");
+ commands.add("exec");
+ commands.add(YarnClusterAndHiveDockerResource.ContainerRole.YARN_MASTER.getContainerName());
+ commands.add("bash");
+ commands.add("-c");
+ StringBuilder flinkRunCommand = new StringBuilder();
+ flinkRunCommand.append("export HADOOP_CLASSPATH=`hadoop classpath` && ");
+ flinkRunCommand.append(String.format("%s/bin/flink run -m yarn-cluster ", flinkResource.remoteFlinkDir));
+ flinkRunCommand.append(StringUtils.join(job.getOptions(), " "));
+ flinkRunCommand.append(String.format(" %s ", targetPath));
+ flinkRunCommand.append(StringUtils.join(job.getArguments(), " "));
+ commands.add(flinkRunCommand.toString());
+ AutoClosableProcess.AutoClosableProcessBuilder autoClosableProcessBuilder =
+ AutoClosableProcess.create(commands.toArray(new String[commands.size()]));
+ List<String> lines = new ArrayList<>();
+ autoClosableProcessBuilder.setStdoutProcessor(s -> lines.add(s));
+ autoClosableProcessBuilder.runBlocking(Duration.ofMinutes(10));
+ return new YarnClusterJobController(lines);
+ }
+
+ /**
+ * Trigger the closing of the resource and return the corresponding
+ * close future.
+ *
+ * @return Future which is completed once the resource has been closed
+ */
+ @Override
+ public CompletableFuture<Void> closeAsync() {
+ return CompletableFuture.completedFuture(null);
+ }
+ }
+
+ /**
+ * YarnClusterJobController can be used to fetch the execute log.
+ */
+ public static class YarnClusterJobController implements JobController {
+ private List<String> lines;
Review comment:
make it final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#discussion_r365150036
##########
File path: flink-end-to-end-tests/flink-connector-hive-test/src/main/java/org/apache/flink/tests/util/hive/YarnClusterFlinkResource.java
##########
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hive;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.GlobalConfiguration;
+import org.apache.flink.configuration.UnmodifiableConfiguration;
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.TestUtils;
+import org.apache.flink.tests.util.flink.ClusterController;
+import org.apache.flink.tests.util.flink.FlinkResource;
+import org.apache.flink.tests.util.flink.JobController;
+import org.apache.flink.tests.util.flink.JobSubmission;
+
+import org.apache.commons.lang3.StringUtils;
+import org.junit.Assert;
+import org.junit.rules.TemporaryFolder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.UUID;
+import java.util.concurrent.CompletableFuture;
+import java.util.stream.Collectors;
+
+/**
+ * YarnClusterFlinkResource use the {@link YarnClusterAndHiveResource} as the yarn cluster to submit flink job in
+ * per-job mode.
+ */
+public class YarnClusterFlinkResource implements FlinkResource {
+
+ private static final Logger LOG = LoggerFactory.getLogger(YarnClusterFlinkResource.class);
+ private final YarnClusterAndHiveResource yarnCluster;
+ private final TemporaryFolder temporaryFolder = new TemporaryFolder();
+ private final Path originalFlinkDir;
+ private boolean deployFlinkToRemote = false;
+ public final String remoteFlinkDir = "/home/hadoop-user/flink";
+ Path localFlinkDir;
+ private Configuration defaultConfig;
+ private Path conf;
+
+ public YarnClusterFlinkResource(YarnClusterAndHiveResource yarnCluster) {
+ this.yarnCluster = yarnCluster;
+ final String distDirProperty = System.getProperty("distDir");
+ if (distDirProperty == null) {
+ Assert.fail("The distDir property was not set. You can set it when running maven via -DdistDir=<path> .");
+ }
+ originalFlinkDir = Paths.get(distDirProperty);
+ }
+
+ @Override
+ public void addConfiguration(Configuration config) throws IOException {
+ final Configuration mergedConfig = new Configuration();
+ mergedConfig.addAll(defaultConfig);
+ mergedConfig.addAll(config);
+
+ final List<String> configurationLines = mergedConfig.toMap().entrySet().stream()
+ .map(entry -> entry.getKey() + ": " + entry.getValue())
+ .collect(Collectors.toList());
+
+ Files.write(conf.resolve("flink-conf.yaml"), configurationLines);
+ }
+
+ @Override
+ public ClusterController startCluster(int numTaskManagers) throws IOException {
+ if (!deployFlinkToRemote) {
+ yarnCluster.copyLocalFileToYarnMaster(localFlinkDir.toAbsolutePath().toString(), remoteFlinkDir);
Review comment:
Instead of copying the dist dir to the container, can we instead mount the dir to container when it's started, with the `-v` option?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/142473285",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150762354",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "e580f035522a9ccf395fa571e668dfef834f2695",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5660",
"triggerID" : "e580f035522a9ccf395fa571e668dfef834f2695",
"triggerType" : "PUSH"
}, {
"hash" : "e580f035522a9ccf395fa571e668dfef834f2695",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150771067",
"triggerID" : "e580f035522a9ccf395fa571e668dfef834f2695",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e580f035522a9ccf395fa571e668dfef834f2695 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150771067) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5660)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/142473285",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 31cc4b771858ddf31a5cc19f2d3257b38f944825 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142473285) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#discussion_r365154431
##########
File path: flink-end-to-end-tests/flink-connector-hive-test/src/main/resources/docker-hive-hadoop-cluster/bootstrap.sh
##########
@@ -0,0 +1,87 @@
+#!/bin/bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+: ${HADOOP_PREFIX:=/usr/local/hadoop}
+
+$HADOOP_PREFIX/etc/hadoop/hadoop-env.sh
+
+MAX_RETRY_SECONDS=800
+
+# installing libraries if any - (resource urls added comma separated to the ACP system variable)
+cd $HADOOP_PREFIX/share/hadoop/common ; for cp in ${ACP//,/ }; do echo == $cp; curl -LO $cp ; done; cd -
+
+sed -i "s#/usr/local/hadoop/bin/container-executor#${NM_CONTAINER_EXECUTOR_PATH}#g" $HADOOP_PREFIX/etc/hadoop/yarn-site.xml
+export HADOOP_CLASSPATH=`hadoop classpath`
+
+service ssh start
+
+if [ "$1" == "--help" -o "$1" == "-h" ]; then
+ echo "Usage: $(basename $0) (master|worker|hive)"
+ exit 0
+elif [ "$1" == "master" ]; then
+ yes| sudo -E -u hdfs $HADOOP_PREFIX/bin/hdfs namenode -format
+
+ nohup sudo -E -u hdfs $HADOOP_PREFIX/bin/hdfs namenode 2>> /var/log/hadoop/namenode.err >> /var/log/hadoop/namenode.out &
+ nohup sudo -E -u yarn $HADOOP_PREFIX/bin/yarn resourcemanager 2>> /var/log/hadoop/resourcemanager.err >> /var/log/hadoop/resourcemanager.out &
+ nohup sudo -E -u yarn $HADOOP_PREFIX/bin/yarn timelineserver 2>> /var/log/hadoop/timelineserver.err >> /var/log/hadoop/timelineserver.out &
+ nohup sudo -E -u mapred $HADOOP_PREFIX/bin/mapred historyserver 2>> /var/log/hadoop/historyserver.err >> /var/log/hadoop/historyserver.out &
+
+ hdfs dfsadmin -safemode wait
+ while [ $? -ne 0 ]; do hdfs dfsadmin -safemode wait; done
+
+ hdfs dfs -chown hdfs:hadoop /
Review comment:
I think we have disabled `dfs.permissions`. So why we need to run these `chown`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569303649
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e580f035522a9ccf395fa571e668dfef834f2695 (Fri Feb 28 21:48:31 UTC 2020)
**Warnings:**
* **3 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
Hash:31cc4b771858ddf31a5cc19f2d3257b38f944825 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142473285 TriggerType:PUSH TriggerID:31cc4b771858ddf31a5cc19f2d3257b38f944825
Hash:31cc4b771858ddf31a5cc19f2d3257b38f944825 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962 TriggerType:PUSH TriggerID:31cc4b771858ddf31a5cc19f2d3257b38f944825
-->
## CI report:
* 31cc4b771858ddf31a5cc19f2d3257b38f944825 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142473285) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #10709: [FLINK-13437][test]
Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-573443701
@lirui-apache @JingsongLi can you guys help review? I can help merge once it passes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zjuwangg commented on issue #10709: [FLINK-13437][test] Add
Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569303439
cc @bowenli86 @xuefuz @JingsongLi @KurtYoung @lirui-apache to have a review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#discussion_r365137287
##########
File path: flink-end-to-end-tests/flink-connector-hive-test/src/main/java/org/apache/flink/tests/util/hive/YarnClusterAndHiveDockerResource.java
##########
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util.hive;
+
+import org.apache.flink.tests.util.AutoClosableProcess;
+import org.apache.flink.tests.util.CommandLineWrapper;
+import org.apache.flink.tests.util.activation.OperatingSystemRestriction;
+import org.apache.flink.util.OperatingSystem;
+
+import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Objects;
+
+/**
+ * A docker based YarnCluster and hive service wrapper resource.
+ */
+public class YarnClusterAndHiveDockerResource implements YarnClusterAndHiveResource {
+
+ /**
+ * Enum to represent the different role in this yarn cluster and hive service.
+ */
+ public enum ContainerRole {
+ YARN_MASTER("master"),
+ YARN_SLAVE1("slave1"),
+ YARN_SLAVE2("slave2"),
+ MYSQL("mysql"),
+ HIVE("hive");
+
+ private String containerName;
+
+ ContainerRole(String containerName) {
+ this.containerName = containerName;
+ }
+
+ public String getContainerName() {
+ return containerName;
+ }
+ }
+
+ private static final Logger LOG = LoggerFactory.getLogger(YarnClusterAndHiveResource.class);
+ private final String hiveVersion;
+ private final String hadoopVersion;
+ private final String dockerFilePath;
+
+ public YarnClusterAndHiveDockerResource(String hiveVersion, String hadoopVersion) {
+ OperatingSystemRestriction.forbid(
+ String.format("The %s relies on UNIX utils and shell scripts.", getClass().getSimpleName()),
+ OperatingSystem.WINDOWS);
+ this.hiveVersion = hiveVersion;
+ this.hadoopVersion = hadoopVersion;
+ dockerFilePath = getClass().getClassLoader().getResource("docker-hive-hadoop-cluster").getFile();
+ }
+
+ private void buildDockerImage() throws IOException {
+ LOG.info("begin to build YarnHiveDockerImage!");
+ AutoClosableProcess.runBlocking(
+ Duration.ofMinutes(10),
+ new CommandLineWrapper.DockerBuildBuilder()
+ .buildArg(String.format("HADOOP_VERSION=%s", hadoopVersion))
+ .buildArg(String.format("HIVE_VERSION=%s", hiveVersion))
+ .tag("flink/flink-hadoop-hive-cluster:latest")
+ .buildPath(dockerFilePath)
+ .build());
+ }
+
+ @Override
+ public void startYarnClusterAndHiveServer() throws IOException{
+ LOG.info("begin to start yarn cluster and hive server");
+ String[] startCommands = String.format("docker-compose -f %s/docker-compose.yml up -d", dockerFilePath)
+ .split("\\s+");
+ AutoClosableProcess.runBlocking(Duration.ofMinutes(10), startCommands);
+ String[] waitCommands = String.format("bash %s/wait_yarn_cluster_hive_start.sh", dockerFilePath)
+ .split("\\s+");
+ AutoClosableProcess.runBlocking(Duration.ofMinutes(5), waitCommands);
+ LOG.info("Start yarn cluster and hive server success");
+ }
+
+ @Override
+ public void stopYarnClusterAndHiveServer() throws IOException {
+ LOG.info("begin to stop yarn cluster and hive server");
+ String[] commands = String.format("docker-compose -f %s/docker-compose.yml down", dockerFilePath)
+ .split("\\s+");
+ AutoClosableProcess.runBlocking(Duration.ofMinutes(1), commands);
+ LOG.info("Stop yarn cluster and hive server success");
+ }
+
+ @Override
+ public String execHiveSql(String sql) throws IOException {
+ LOG.info(String.format("execute sql:%s on hive container", sql));
+ String[] commands = new DockerExecBuilder(ContainerRole.HIVE.getContainerName())
+ .command("hive").arg("-e").arg(sql).build();
+ AutoClosableProcess.AutoClosableProcessBuilder autoClosableProcessBuilder =
+ AutoClosableProcess.create(commands);
+ List<String> lines = new ArrayList<>();
+ autoClosableProcessBuilder.setStdoutProcessor(s -> lines.add(s));
+ autoClosableProcessBuilder.runBlocking(Duration.ofMinutes(3));
+ return StringUtils.join(lines, "\n");
+ }
+
+ @Override
+ public void copyLocalFileToHiveGateWay(String localPath, String remotePath) throws IOException {
+ LOG.info(String.format("copy localPath %s to hive container path %s", localPath, remotePath));
+ String[] commands = String.format("docker cp %s %s:%s",
+ localPath, ContainerRole.HIVE.getContainerName(), remotePath).split("\\s+");
+ AutoClosableProcess.runBlocking(commands);
+ }
+
+ @Override
+ public void copyLocalFileToYarnMaster(String localPath, String remotePath) throws IOException {
+ LOG.info(String.format("copy localPath %s to yarn master path %s", localPath, remotePath));
+ String[] commands = String.format("docker cp %s %s:%s",
+ localPath, ContainerRole.YARN_MASTER.getContainerName(), remotePath).split("\\s+");
+ AutoClosableProcess.runBlocking(commands);
+ }
+
+ @Override
+ public void before() throws Exception {
+ buildDockerImage();
Review comment:
IIUC, building the docker image will take a while for the 1st time, and will be pretty fast for later runs, correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#discussion_r365152997
##########
File path: flink-end-to-end-tests/flink-connector-hive-test/src/main/resources/docker-hive-hadoop-cluster/bootstrap.sh
##########
@@ -0,0 +1,87 @@
+#!/bin/bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+: ${HADOOP_PREFIX:=/usr/local/hadoop}
+
+$HADOOP_PREFIX/etc/hadoop/hadoop-env.sh
+
+MAX_RETRY_SECONDS=800
+
+# installing libraries if any - (resource urls added comma separated to the ACP system variable)
+cd $HADOOP_PREFIX/share/hadoop/common ; for cp in ${ACP//,/ }; do echo == $cp; curl -LO $cp ; done; cd -
+
+sed -i "s#/usr/local/hadoop/bin/container-executor#${NM_CONTAINER_EXECUTOR_PATH}#g" $HADOOP_PREFIX/etc/hadoop/yarn-site.xml
+export HADOOP_CLASSPATH=`hadoop classpath`
+
+service ssh start
+
+if [ "$1" == "--help" -o "$1" == "-h" ]; then
+ echo "Usage: $(basename $0) (master|worker|hive)"
+ exit 0
+elif [ "$1" == "master" ]; then
+ yes| sudo -E -u hdfs $HADOOP_PREFIX/bin/hdfs namenode -format
+
+ nohup sudo -E -u hdfs $HADOOP_PREFIX/bin/hdfs namenode 2>> /var/log/hadoop/namenode.err >> /var/log/hadoop/namenode.out &
+ nohup sudo -E -u yarn $HADOOP_PREFIX/bin/yarn resourcemanager 2>> /var/log/hadoop/resourcemanager.err >> /var/log/hadoop/resourcemanager.out &
+ nohup sudo -E -u yarn $HADOOP_PREFIX/bin/yarn timelineserver 2>> /var/log/hadoop/timelineserver.err >> /var/log/hadoop/timelineserver.out &
+ nohup sudo -E -u mapred $HADOOP_PREFIX/bin/mapred historyserver 2>> /var/log/hadoop/historyserver.err >> /var/log/hadoop/historyserver.out &
+
+ hdfs dfsadmin -safemode wait
+ while [ $? -ne 0 ]; do hdfs dfsadmin -safemode wait; done
Review comment:
Why do we want to retry if the command fails? I think it's a potential infinite loop if something goes wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zjuwangg commented on issue #10709: [FLINK-13437][test] Add
Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
zjuwangg commented on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569303511
It's a base work, and we can add more ITCase based on this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10709:
[FLINK-13437][test] Add Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/142473285",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3962",
"triggerID" : "31cc4b771858ddf31a5cc19f2d3257b38f944825",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150762354",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
}, {
"hash" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657",
"triggerID" : "889c2d9112462f22e6e8f4af9ba85b07b5f3c424",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 889c2d9112462f22e6e8f4af9ba85b07b5f3c424 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150762354) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5657)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10709: [FLINK-13437][test] Add
Hive SQL E2E test
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10709: [FLINK-13437][test] Add Hive SQL E2E test
URL: https://github.com/apache/flink/pull/10709#issuecomment-569310266
<!--
Meta data
Hash:31cc4b771858ddf31a5cc19f2d3257b38f944825 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:31cc4b771858ddf31a5cc19f2d3257b38f944825
-->
## CI report:
* 31cc4b771858ddf31a5cc19f2d3257b38f944825 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services