You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/04 14:16:16 UTC
[GitHub] [arrow] sjperkins opened a new pull request #10452: [ARROW-638]: [C++] Complex Number Support
sjperkins opened a new pull request #10452:
URL: https://github.com/apache/arrow/pull/10452
xref https://issues.apache.org/jira/browse/ARROW-638
Added COMPLEX_FLOAT and COMPLEX_DOUBLE types to the flatbuffers definition in feather.fbs as an initial stab.
This is a draft and I've some questions before proceeding foreward:
- Complex valued types are standard types so my impression would be that base types should exist for them in Arrow.
- But this looks like it may be a breaking format change (V5 to V6). Is this undesirable?
- Alternatively, what would be lost by implementing this as an [C++ Extension Type](https://issues.apache.org/jira/browse/ARROW-638?focusedCommentId=16912456&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16912456
)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10452: ARROW-638: [C++] Complex Number Support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10452:
URL: https://github.com/apache/arrow/pull/10452#issuecomment-856352006
https://issues.apache.org/jira/browse/ARROW-638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10452: [ARROW-638]: [C++] Complex Number Support
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10452:
URL: https://github.com/apache/arrow/pull/10452#issuecomment-856070417
I think it would be best to start a discussion on the [dev mailing-list](https://arrow.apache.org/community/) to gauge interest and support for this. @sjperkins Do you want to do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10452: [ARROW-638]: [C++] Complex Number Support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10452:
URL: https://github.com/apache/arrow/pull/10452#issuecomment-854763099
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sjperkins commented on pull request #10452: ARROW-638: [C++] Complex Number Support
Posted by GitBox <gi...@apache.org>.
sjperkins commented on pull request #10452:
URL: https://github.com/apache/arrow/pull/10452#issuecomment-865008898
https://github.com/apache/arrow/pull/10565 contains the PR implementing Complex Numbers as Extension Types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sjperkins commented on pull request #10452: ARROW-638: [C++] Complex Number Support
Posted by GitBox <gi...@apache.org>.
sjperkins commented on pull request #10452:
URL: https://github.com/apache/arrow/pull/10452#issuecomment-865008898
https://github.com/apache/arrow/pull/10565 contains the PR implementing Complex Numbers as Extension Types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org