You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by darionyaphet <gi...@git.apache.org> on 2016/07/11 13:39:28 UTC
[GitHub] storm pull request #1550: [STORM-1957] Support Storm JDBC batch insert
GitHub user darionyaphet opened a pull request:
https://github.com/apache/storm/pull/1550
[STORM-1957] Support Storm JDBC batch insert
[STORM-1957 Support Storm JDBC batch insert](https://issues.apache.org/jira/browse/STORM-1957?jql=project%20%3D%20STORM)
Batch insert support execute grouped SQL a batch and submit into one call . It can reduce the amount of communication , improving performance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/darionyaphet/storm STORM-1957
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1550.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1550
----
commit adbed94e51453c7dd3d69629f0cd8fc90061614d
Author: darionyaphet <da...@gmail.com>
Date: 2016-07-11T13:36:48Z
STORM-1957 Support Storm JDBC batch insert
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1550: [STORM-1957] Support Storm JDBC batch insert
Posted by bigbang4u2 <gi...@git.apache.org>.
Github user bigbang4u2 commented on the issue:
https://github.com/apache/storm/pull/1550
I am wondering why this never got pushed into master branch. I don't see this as a part of mater branch https://github.com/apache/storm/blob/master/external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcInsertBolt.java
---
[GitHub] storm pull request #1550: [STORM-1957] Support Storm JDBC batch insert
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1550#discussion_r96109605
--- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcInsertBolt.java ---
@@ -43,12 +43,14 @@
private String tableName;
private String insertQuery;
private JdbcMapper jdbcMapper;
+ private int batchSize;
public JdbcInsertBolt(ConnectionProvider connectionProvider, JdbcMapper jdbcMapper) {
super(connectionProvider);
Validate.notNull(jdbcMapper);
this.jdbcMapper = jdbcMapper;
+ this.batchSize = 0;
--- End diff --
lets have a default value of 100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1550: [STORM-1957] Support Storm JDBC batch insert
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1550
@bigbang4u2 We bulk closed old unmerged pull requests a while ago. This PR wasn't approved, and wasn't updated for a long time, so it was closed. If you want this feature to get merged, you would be welcome to take over the issue and open a new PR for it.
---
[GitHub] storm pull request #1550: [STORM-1957] Support Storm JDBC batch insert
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1550
---