You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/28 00:16:33 UTC
[kudu-CR] master-test: fix another source of test flakiness
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8160
to review the following change.
Change subject: master-test: fix another source of test flakiness
......................................................................
master-test: fix another source of test flakiness
This timeout is behind one failure on the flaky test dashboard:
/data/jenkins-workspace/kudu-workspace/src/kudu/master/master-test.cc:110: Failure
Failed
Bad status: Timed out: Maximum time exceeded waiting for master leadership: OK
Change-Id: I65c7eae0afb2774cbe756007ef6b8d7fa66f2cd9
---
M src/kudu/master/master-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/8160/1
--
To view, visit http://gerrit.cloudera.org:8080/8160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65c7eae0afb2774cbe756007ef6b8d7fa66f2cd9
Gerrit-Change-Number: 8160
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] master-test: fix another source of test flakiness
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8160 )
Change subject: master-test: fix another source of test flakiness
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8160/1/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/8160/1/src/kudu/master/master-test.cc@111
PS1, Line 111: 90
> Is this necessary only for ASAN/TSAN builds or for DEBUG/RELEASE builds as
The failure on the dashboard was for RELEASE.
To be honest, I think we spend way too much time dwelling on "lowest possible" test timeout values, and then bumping them when flakes show up. I think we're better off using absurdly high timeout values and letting the 900s test timeout kick in when there's an actual bug.
--
To view, visit http://gerrit.cloudera.org:8080/8160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65c7eae0afb2774cbe756007ef6b8d7fa66f2cd9
Gerrit-Change-Number: 8160
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 00:33:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] master-test: fix another source of test flakiness
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8160 )
Change subject: master-test: fix another source of test flakiness
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8160/1/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/8160/1/src/kudu/master/master-test.cc@111
PS1, Line 111: 90
Is this necessary only for ASAN/TSAN builds or for DEBUG/RELEASE builds as well?
--
To view, visit http://gerrit.cloudera.org:8080/8160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65c7eae0afb2774cbe756007ef6b8d7fa66f2cd9
Gerrit-Change-Number: 8160
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 00:24:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] master-test: fix another source of test flakiness
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8160 )
Change subject: master-test: fix another source of test flakiness
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8160/1/src/kudu/master/master-test.cc
File src/kudu/master/master-test.cc:
http://gerrit.cloudera.org:8080/#/c/8160/1/src/kudu/master/master-test.cc@111
PS1, Line 111: 90
> The failure on the dashboard was for RELEASE.
+1
--
To view, visit http://gerrit.cloudera.org:8080/8160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65c7eae0afb2774cbe756007ef6b8d7fa66f2cd9
Gerrit-Change-Number: 8160
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 00:41:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] master-test: fix another source of test flakiness
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8160 )
Change subject: master-test: fix another source of test flakiness
......................................................................
master-test: fix another source of test flakiness
This timeout is behind one failure on the flaky test dashboard:
/data/jenkins-workspace/kudu-workspace/src/kudu/master/master-test.cc:110: Failure
Failed
Bad status: Timed out: Maximum time exceeded waiting for master leadership: OK
Change-Id: I65c7eae0afb2774cbe756007ef6b8d7fa66f2cd9
Reviewed-on: http://gerrit.cloudera.org:8080/8160
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/master-test.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I65c7eae0afb2774cbe756007ef6b8d7fa66f2cd9
Gerrit-Change-Number: 8160
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins