[GitHub] [incubator-mxnet] larroy edited a comment on issue #15375: Memory leak in Naive engine when profiling

[GitBox <gi...@apache.org>]

larroy edited a comment on issue #15375: Memory leak in Naive engine when profiling
URL: https://github.com/apache/incubator-mxnet/issues/15375#issuecomment-506843795
 
 
   @anirudh2290 I proposed refactoring around a unique_ptr I don't think is going to change the way memory is released, maybe you got a different impression of what I was suggesting to do. I don't know why are you oposing a proposed change right away without considering the benefits. Having a pointer released in a call hiearchy 3 levels down leads to bugs and memory leaks, is difficult to reason about it. Best is to use RAII and return a unique_ptr or similar which holds ownership. I don't think the way the release of resources is going to be modified or performance impacted in any way, but If the proposal is blocked from the start makes no sense to even propose a PR, this is not very encouraging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services