You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by kylape <gi...@git.apache.org> on 2014/10/10 23:35:01 UTC
[GitHub] cxf pull request: [CXF-6038] Only add the handler interceptors onc...
GitHub user kylape opened a pull request:
https://github.com/apache/cxf/pull/25
[CXF-6038] Only add the handler interceptors once
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kylape/cxf cxf-6038
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit a4d64d349832bcd413222fddd37d613eb7e78112
Author: Kyle Lape <ky...@redhat.com>
Date: 2014-10-10T21:34:07Z
[CXF-6038] Only add the handler interceptors once
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: [CXF-6038] Only add the handler interceptors onc...
Posted by kylape <gi...@git.apache.org>.
Github user kylape closed the pull request at:
https://github.com/apache/cxf/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: [CXF-6038] Only add the handler interceptors onc...
Posted by kylape <gi...@git.apache.org>.
Github user kylape commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61220541
Okay, I reproduced the issue with CXF 3.0.2 and verified it is resolved in my build of the master branch today.
Just FYI -- in JBoss I only had to add this code:
```
final Service service = Service.create(wsdl, ns);
service.setHandlerResolver(new HandlerResolver() {
public List<Handler> getHandlerChain(PortInfo info) {
return handlerChain;
}
});
```
because the JBossWS integration calls `setHandlerChain` for every invocation to ensure handler order (perhaps that could be improved upon as well?). When using CXF without JBossWS integration, I had to call `((BindingProvider)port).getBinding().setHandlerChain(handlerChain)` for every invocation to reproduce the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: [CXF-6038] Only add the handler interceptors onc...
Posted by asoldano <gi...@git.apache.org>.
Github user asoldano commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61260523
@kylape just for the record... I fixed JBossWS to avoid calling setHandlerChain(..) at every invocation :-) see https://source.jboss.org/changelog/JBossWS?cs=19036
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cxf pull request: [CXF-6038] Only add the handler
interceptors onc...
Posted by Laxmi Narayan NIT DGP <ni...@gmail.com>.
can i post my question in this list ??
* Laxmi Narayan Patel*
* MCA NIT Durgapur (2011-2014)*
* Mob:- 8345847473 *
On Thu, Oct 30, 2014 at 2:29 AM, dkulp <gi...@git.apache.org> wrote:
> Github user dkulp commented on the pull request:
>
> https://github.com/apache/cxf/pull/25#issuecomment-61003841
>
> This has been merged. Can you please verify and close? Thanks!
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cxf pull request: [CXF-6038] Only add the handler interceptors onc...
Posted by dkulp <gi...@git.apache.org>.
Github user dkulp commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61003841
This has been merged. Can you please verify and close? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: [CXF-6038] Only add the handler interceptors onc...
Posted by kylape <gi...@git.apache.org>.
Github user kylape commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61281462
Ah, nice. Thanks, Alessio!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request: [CXF-6038] Only add the handler interceptors onc...
Posted by kylape <gi...@git.apache.org>.
Github user kylape commented on the pull request:
https://github.com/apache/cxf/pull/25#issuecomment-61172618
I've verified the fix on CXF 2.7.12 (the version in JBoss EAP) already, but I'll work to verify on CXF master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---