You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/05/18 00:11:45 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #41206: [SPARK-43509][PYTHON][CONNECT][FOLLOW-UP] Set SPARK_CONNECT_MODE_ENABLED when running pyspark shell with remote is local

HyukjinKwon commented on code in PR #41206:
URL: https://github.com/apache/spark/pull/41206#discussion_r1197200251


##########
python/pyspark/shell.py:
##########
@@ -100,10 +100,9 @@
     % (platform.python_version(), platform.python_build()[0], platform.python_build()[1])
 )
 if is_remote():
-    print(
-        "Client connected to the Spark Connect server at %s"
-        % urlparse(os.environ["SPARK_REMOTE"]).netloc
-    )
+    url = os.environ("SPARK_REMOTE", None)

Review Comment:
   ```suggestion
       url = os.environ.get("SPARK_REMOTE", None)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org