You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/03/03 05:49:45 UTC

[GitHub] incubator-weex pull request #23: * [android] fix the ConcurrentModificationE...

GitHub user misakuo opened a pull request:

    https://github.com/apache/incubator-weex/pull/23

    * [android] fix the ConcurrentModificationException

    The exception:
    ![\u7c98\u8d34\u56fe\u7247.png](https://ooo.0o0.ooo/2017/03/03/58b901868d7f7.png)    
    
    Is due to one thread to modify the ArrayList while another thread is iterating over it, replacing the `ArrayList` with `CopyToWriteArrayList` should be able to solve it

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/misakuo/incubator-weex android-bugfix-concurrentmodifyexception

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 2280cef5a34eb505a6d4d911e438f9703b5ed7da
Author: moxun.ljf <mo...@alibaba-inc.com>
Date:   2017-03-03T05:36:42Z

    * [android] fix the ConcurrentModificationException

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #23: * [android] fix the ConcurrentModificationE...

Posted by misakuo <gi...@git.apache.org>.

Github user misakuo closed the pull request at:

    https://github.com/apache/incubator-weex/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #23: * [android] fix the ConcurrentModificationExceptio...

Posted by misakuo <gi...@git.apache.org>.

Github user misakuo commented on the issue:

    https://github.com/apache/incubator-weex/pull/23
  
    looks like the inspector's problem, close this pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #23: * [android] fix the ConcurrentModificationExceptio...

Posted by sospartan <gi...@git.apache.org>.

Github user sospartan commented on the issue:

    https://github.com/apache/incubator-weex/pull/23
  
    This data should only be access by JS thread, u should figure that out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #23: * [android] fix the ConcurrentModificationExceptio...

Posted by weex-bot <gi...@git.apache.org>.

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/23
  
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true" data-kind="Message">
              1 Message
          </th>
         </tr>
      </thead>
      <tbody>
        <tr>
          <td>:book:</td>
          <td data-sticky="false">Executed 53 tests, with 0 failures (0 unexpected) in 61.703 (62.071) seconds</td>
        </tr>
      </tbody>
    </table>
    
    <p align="right" data-meta="generated_by_danger">
      Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #23: * [android] fix the ConcurrentModificationExceptio...

Posted by misakuo <gi...@git.apache.org>.

Github user misakuo commented on the issue:

    https://github.com/apache/incubator-weex/pull/23
  
    @sospartan review please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---