[jira] [Created] (BEAM-6503) PCollectionViews$SimplePCollectionView.hashCode once again allocates memory (fix reverted, then fixed again)

["Kenneth Knowles (JIRA)" <ji...@apache.org>]

Kenneth Knowles created BEAM-6503:
-------------------------------------

             Summary: PCollectionViews$SimplePCollectionView.hashCode once again allocates memory (fix reverted, then fixed again)
                 Key: BEAM-6503
                 URL: https://issues.apache.org/jira/browse/BEAM-6503
             Project: Beam
          Issue Type: Improvement
          Components: sdk-java-core
    Affects Versions: 2.8.0
            Reporter: Vojtech Janota
            Assignee: Vojtech Janota
             Fix For: 2.9.0


I'm currently profiling memory consumption of our Beam pipeline and have noticed that

    org.apache.beam.sdk.values.PCollectionViews$SimplePCollectionView.hashCode()

makes noticeable heap allocations. The implementation is:

    return Objects.hash(tag);

That itself translates to:

    return Arrays.hashCode(values);

Which performs implicit array creation in order to call:

    public static int Arrays.hashCode(Object a[]);

Instead of the helper call, doing simple:

    tag.hashCode();

Seems more appropriate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)