You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Michael Brohl (Jira)" <ji...@apache.org> on 2020/03/08 10:47:00 UTC

[jira] [Comment Edited] (OFBIZ-10407) create a docker image from the ofbiz system

    [ https://issues.apache.org/jira/browse/OFBIZ-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054366#comment-17054366 ] 

Michael Brohl edited comment on OFBIZ-10407 at 3/8/20, 10:46 AM:
-----------------------------------------------------------------

The recommended distro for Open JDK is Adopt Open JDK which is not just another download location. Maybe we should make it more clear in the README but it should not prevent us from using it in our official Repo/dists.

Since the Docker image(s) are just for testing and evalution purposes as you stated, it should not matter that the code is installed in another directory (/opt, which is not so unusual for the installation of additional software packages).

I don't see any reason to install additional software packages which are not needed so why not remove them to a minimum? It makes the build time shorter and maintenance easier. The current dockerfile seems to be a stripped down version from Yetus and is not tailored to fit our needs.

I'll work on an alternative which will address my concerns so that we will have a selection to chose from.

As for the location to provide them, we should hear what others have to say. I also imagine to provide the different images on the docker hub like many other Apache projects do so it might be reasonable to think that way.

 


was (Author: mbrohl):
The recommended distro for Open JDK is Adopt Open JDK which is not just another download location. Maybe we should make it more clear in the README but it should not prevent us from using it in our official Repo/dists.

Since the Docker image(s) are just for testing and evalution purposes as you stated, it should not matter that the code is installed in another directory (/opt, which is not so unusual for the installation of additional software packages).

I don't see any reason to install additional software packages which are not needed so why not remove them to a minimum? It makes the build time shorter and maintenance easier.

I'll work on an alternative which will address my concerns so that we will have a selection to chose from.

As for the location to provide them, we should hear what others have to say. I also imagine to provide the different images on the docker hub like many other Apache projects do so it might be reasonable to think that way.

 

> create a docker image from the ofbiz system
> -------------------------------------------
>
>                 Key: OFBIZ-10407
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10407
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: Trunk
>            Reporter: Hans Bakker
>            Priority: Major
>              Labels: DevOps
>         Attachments: docker.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Attached an initial docker version from OFBiz copied from our GrowERP production system translated to svn repositories.
> I propose to create a docker directory in the ofbiz framework root of which a patch is attached.
> The image result is stored in hub.docker.com under the name ofbiz/full-trunk.
> It can be started in a docker environment with the following command:
> docker run -p 80:8080 -p 443:8443 ofbiz/full-trunk
>  and after about 30 seconds it can be show in the browser under:
>  [https://0.0.0.0/catalog/control/main]
>  the image can be created by executing this command in the ofbiz root when the patch is applied:
>  docker build -t ofbiz/full-trunk docker
> the password to the ofbiz account at hub.docker.com will be supplied upon request.
>   
> see the discussion in the mailinglist at https://markmail.org/message/n7wcgroslj7v3gfe?q=docker+ofbiz
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)