You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/04/01 00:05:06 UTC
Re: Review Request 45383: Implemented recover() method of
"network/cni" isolator.
> On March 30, 2016, 6:12 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 339
> > <https://reviews.apache.org/r/45383/diff/4/?file=1319540#file1319540line339>
> >
> > I think this is not needed because if recover fails, slave will restart.
>
> Qian Zhang wrote:
> Agree, but I see other isolators do the similar, e.g., CgroupsCpushareIsolatorProcess::recover(), CgroupsMemIsolatorProcess::recover(), etc., maybe we need to fix them as well?
yeah, those are not done correctly.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45383/#review126143
-----------------------------------------------------------
On March 31, 2016, 11:33 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45383/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 11:33 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented recover() method of "network/cni" isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 873e0c52475f4868e611bd24a6782ad5eb261a99
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 1c8e231813c0579b79681c5d18b1f799a727ead7
> src/slave/containerizer/mesos/isolators/network/cni/paths.hpp f627ec9499a34ca104d2c1a4d28e1d2f4b849f64
> src/slave/containerizer/mesos/isolators/network/cni/paths.cpp 611f3869402b9033081b7f9ecc1bdf006f61918b
> src/slave/containerizer/mesos/isolators/network/cni/spec.hpp 6a3c33645bab73edaf5af4d298a671852ea59c46
> src/slave/containerizer/mesos/isolators/network/cni/spec.cpp 5b5f904def9ef6dcc4462a03a2d024ad4eb3d946
>
> Diff: https://reviews.apache.org/r/45383/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>