[GitHub] HyukjinKwon commented on a change in pull request #23545: [SPARK-25196][SQL][WIP] Extends Analyze commands for cached tables

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #23545: [SPARK-25196][SQL][WIP] Extends Analyze commands for cached tables
URL: https://github.com/apache/spark/pull/23545#discussion_r247758969
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
 ##########
 @@ -163,7 +163,7 @@ case class InMemoryRelation(
     output: Seq[Attribute],
     @transient cacheBuilder: CachedRDDBuilder,
     override val outputOrdering: Seq[SortOrder])(
-    statsOfPlanToCache: Statistics)
+    var statsOfPlanToCache: Statistics)
 
 Review comment:
   it's just a nit but I think `var` on case class is discouraged per https://github.com/databricks/scala-style-guide#case-classes-and-immutability

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org