You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/24 12:01:49 UTC

[GitHub] XD-DENG commented on a change in pull request #4577: [AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly

XD-DENG commented on a change in pull request #4577: [AIRFLOW-3761] Decommission User & Chart models & Update doc accordingly
URL: https://github.com/apache/airflow/pull/4577#discussion_r250577500
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -271,9 +271,6 @@ access_logfile = -
 error_logfile = -
 
 # Expose the configuration file in the web server
-# This is only applicable for the flask-admin based web UI (non FAB-based).
-# In the FAB-based web UI with RBAC feature,
-# access to configuration is controlled by role permissions.
 
 Review comment:
   In 1.10.2, I remember I found that config was hidden even if for Admin. So I suspect that `expose_config` is also applicable for RBAC UI now (possibly due to some new commit). If you check the codebase, "expose_config" is still used somewhere.
   
   So I didn't remove this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services