You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2019/01/02 07:02:02 UTC

[GitHub] carbondata pull request #2971: [CARBONDATA-3219] Support range partition the...

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2971#discussion_r244670461
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala ---
    @@ -156,4 +161,206 @@ object DataLoadProcessBuilderOnSpark {
           Array((uniqueLoadStatusId, (loadMetadataDetails, executionErrors)))
         }
       }
    +
    +  /**
    +   * 1. range partition the whole input data
    +   * 2. for each range, sort the data and writ it to CarbonData files
    +   */
    +  def loadDataUsingRangeSort(
    --- End diff --
    
    Code is duplicated with method `loadDataUsingGlobalSort` , please try to extract common code and reuse here.


---