You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dave Cahill <dc...@midokura.com> on 2013/09/04 07:15:20 UTC
Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in
4.2 for MidoNet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13759/
-----------------------------------------------------------
(Updated Sept. 4, 2013, 5:15 a.m.)
Review request for cloudstack and Sheng Yang.
Changes
-------
Hi Sheng,
I checked and this still applies cleanly to master - would you mind applying it?
Thanks,
Dave.
Bugs: CLOUDSTACK-4466
Repository: cloudstack-git
Description
-------
Changes in this patch are entirely confined to the MidoNet plugin itself.
A recent code change in NetworkManager causes NullPointerExceptions when DHCP capability list is null.
The commit which made the NetworkManager change also changed the VirtualRouter to not use null for the capabilitylist, but didn't make this change for other network devices, causing DHCP to fail on MidoNet.
This change also updates the MidoNet plugin to use the most recent MidoNet API.
Diffs
-----
plugins/network-elements/midonet/pom.xml 9d6588b
plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 85814ef
plugins/network-elements/midonet/src/com/cloud/network/element/SimpleFirewallRule.java a6b78d8
plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java ac77cf6
plugins/network-elements/midonet/src/com/cloud/network/resource/MidoNetVifDriver.java 3c7c23d
plugins/network-elements/midonet/test/com/cloud/network/element/MidoNetElementTest.java 9023c6e
Diff: https://reviews.apache.org/r/13759/diff/
Testing
-------
Removed Maven cache (rm -rf ~/.m2/repository) and built successfully, tests passed.
Spun up several networks and VMs, tested ping to outside, ping VM to VM, DHCP, Source NAT, Static NAT, Port Forwarding.
Thanks,
Dave Cahill
Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in
4.2 for MidoNet
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13759/#review26016
-----------------------------------------------------------
Commit 28af817fcc835c10e4a21f08e971041325ad206d in branch refs/heads/master from Dave Cahill
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=28af817 ]
CLOUDSTACK-4466: Fix DHCP capability breaks in 4.2 for MidoNet
A recent code change in NetworkManager causes NullPointerExceptions when DHCP
capability list is null.
The commit which made the NetworkManager change also changed the VirtualRouter
to not use null for the capabilitylist, but didn't make this change for other
network devices, causing DHCP to fail on MidoNet.
This change also updates the MidoNet plugin to use the most recent MidoNet API.
- ASF Subversion and Git Services
On Sept. 4, 2013, 5:15 a.m., Dave Cahill wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13759/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2013, 5:15 a.m.)
>
>
> Review request for cloudstack and Sheng Yang.
>
>
> Bugs: CLOUDSTACK-4466
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Changes in this patch are entirely confined to the MidoNet plugin itself.
>
> A recent code change in NetworkManager causes NullPointerExceptions when DHCP capability list is null.
> The commit which made the NetworkManager change also changed the VirtualRouter to not use null for the capabilitylist, but didn't make this change for other network devices, causing DHCP to fail on MidoNet.
>
> This change also updates the MidoNet plugin to use the most recent MidoNet API.
>
>
> Diffs
> -----
>
> plugins/network-elements/midonet/pom.xml 9d6588b
> plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetElement.java 85814ef
> plugins/network-elements/midonet/src/com/cloud/network/element/SimpleFirewallRule.java a6b78d8
> plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestNetworkGuru.java ac77cf6
> plugins/network-elements/midonet/src/com/cloud/network/resource/MidoNetVifDriver.java 3c7c23d
> plugins/network-elements/midonet/test/com/cloud/network/element/MidoNetElementTest.java 9023c6e
>
> Diff: https://reviews.apache.org/r/13759/diff/
>
>
> Testing
> -------
>
> Removed Maven cache (rm -rf ~/.m2/repository) and built successfully, tests passed.
> Spun up several networks and VMs, tested ping to outside, ping VM to VM, DHCP, Source NAT, Static NAT, Port Forwarding.
>
>
> Thanks,
>
> Dave Cahill
>
>