[GitHub] [geode] DonalEvans opened a new pull request #5969: GEODE-8873: Do not log stack trace for Exception in MessageDispatcher

[GitBox <gi...@apache.org>]

DonalEvans opened a new pull request #5969:
URL: https://github.com/apache/geode/pull/5969


   - For benign exceptions encountered after stopping the MessageDispatcher, do not log the entire Exception stack trace at info level
   
   Authored-by: Donal Evans <do...@vmware.com>
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [N/A] Have you written or updated unit tests to verify your changes?
   
   - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] DonalEvans merged pull request #5969: GEODE-8873: Do not log stack trace for Exception in MessageDispatcher

[GitBox <gi...@apache.org>]

DonalEvans merged pull request #5969:
URL: https://github.com/apache/geode/pull/5969


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] DonalEvans commented on pull request #5969: GEODE-8873: Do not log stack trace for Exception in MessageDispatcher

[GitBox <gi...@apache.org>]

DonalEvans commented on pull request #5969:
URL: https://github.com/apache/geode/pull/5969#issuecomment-769301760


   > This fixes the problem but I'm wondering if the code would be cleaner if you did just one null check on _list_ like
   > 
   > > if (list == null) {
   > > list = Collections.emptyList();
   > > }
   > 
   > Then you could get rid of the rest of the null checks.
   
   I took a slightly different approach to the one suggested, since if `peek()` throws an exception, it would still have been possible for `list` to be null in the last two places it was used. Instantiating `list` at the time of declaration and then using `addAll()` prevents it from ever being null.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org