[jira] Commented: (WICKET-1684) FileUploadField should return FileUpload as its converted input

["Timo Rantalaiho (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604408#action_12604408 ] 

Timo Rantalaiho commented on WICKET-1684:
-----------------------------------------

Seems to make sense to me. This changes existing behavior (currently FileUpload returns the file name), but because convertedInput is now something else than the model object after submit, it's a bug and it' should be OK to break it if someone depends on it.

> FileUploadField should return FileUpload as its converted input
> ---------------------------------------------------------------
>
>                 Key: WICKET-1684
>                 URL: https://issues.apache.org/jira/browse/WICKET-1684
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-M2
>            Reporter: Ned Collyer
>            Priority: Minor
>             Fix For: 1.4-M3
>
>
> FileUploadField should return FileUpload as its converted input so the file can be validated.
> Eg,
> @Override
> protected void convertInput() {
>     setConvertedInput(getFileUpload());
> }
> Apparently MultiFileUploadField handles this (I've checked, it appears to be in the convertValue method).
> For more context see http://www.nabble.com/Best-way-of-validating-FileUploadField-td17662018.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.