You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/16 09:17:59 UTC
[GitHub] [bookkeeper] eolivelli opened a new pull request #2266: Fix method
order in order to make the execution of TestEntryLog predictable
eolivelli opened a new pull request #2266: Fix method order in order to make the execution of TestEntryLog predictable
URL: https://github.com/apache/bookkeeper/pull/2266
### Motivation
TestEntyLog reuses the entryLogger variable across test methods execution, resulting in an unpredictable execution.
We can at least make the test work consistently across environments using JUnit built-in FixMethodOrder annotation
### Changes
@FixMethodOrder(MethodSorters.NAME_ASCENDING)
Fixes #2260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli merged pull request #2266: Fix method order
in order to make the execution of TestEntryLog predictable
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2266: Fix method order in order to make the execution of TestEntryLog predictable
URL: https://github.com/apache/bookkeeper/pull/2266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2266: Fix method order
in order to make the execution of TestEntryLog predictable
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2266: Fix method order in order to make the execution of TestEntryLog predictable
URL: https://github.com/apache/bookkeeper/pull/2266#issuecomment-586865848
This is patch is minimal and it does not effect production code.
I am going to commit it in order to unblock pull requests validation
thanks @atris for checking
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2266: Fix method order
in order to make the execution of TestEntryLog predictable
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2266: Fix method order in order to make the execution of TestEntryLog predictable
URL: https://github.com/apache/bookkeeper/pull/2266#issuecomment-586685052
@jiazhai @sijie with this simple fix TestEntryLog passed on GitHub actions.
Can we commit it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] atris commented on issue #2266: Fix method order in
order to make the execution of TestEntryLog predictable
Posted by GitBox <gi...@apache.org>.
atris commented on issue #2266: Fix method order in order to make the execution of TestEntryLog predictable
URL: https://github.com/apache/bookkeeper/pull/2266#issuecomment-586690763
+1, looks good to me. I tried this locally and cannot reproduce the issue after applying this fix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services