You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/27 07:39:17 UTC

[GitHub] [apisix] yzeng25 opened a new pull request #4681: Note clarifications

yzeng25 opened a new pull request #4681:
URL: https://github.com/apache/apisix/pull/4681


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander merged pull request #4681: docs: add Note clarifications

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4681:
URL: https://github.com/apache/apisix/pull/4681


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] yzeng25 commented on a change in pull request #4681: docs: add Note clarifications

Posted by GitBox <gi...@apache.org>.
yzeng25 commented on a change in pull request #4681:
URL: https://github.com/apache/apisix/pull/4681#discussion_r677925296



##########
File path: docs/zh/latest/getting-started.md
##########
@@ -170,6 +180,16 @@ curl "http://127.0.0.1:9080/apisix/admin/upstreams/1" -H "X-API-KEY: edd1c9f0343
 
 我们使用 `roundrobin` 作为负载均衡机制,并将 `httpbin.org:80` 设置为我们的上游服务,其 ID 为 `1`。更多字段信息,请参阅 [Admin API](./admin-api.md)。
 
+<!--
+#

Review comment:
       It should be good for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] liuxiran commented on a change in pull request #4681: docs: add Note clarifications

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #4681:
URL: https://github.com/apache/apisix/pull/4681#discussion_r677923711



##########
File path: docs/zh/latest/getting-started.md
##########
@@ -170,6 +180,16 @@ curl "http://127.0.0.1:9080/apisix/admin/upstreams/1" -H "X-API-KEY: edd1c9f0343
 
 我们使用 `roundrobin` 作为负载均衡机制,并将 `httpbin.org:80` 设置为我们的上游服务,其 ID 为 `1`。更多字段信息,请参阅 [Admin API](./admin-api.md)。
 
+<!--
+#

Review comment:
       Do we need translate this tip to Chinese? @yzeng25 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org