You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2010/08/12 19:18:18 UTC

[jira] Closed: (THRIFT-403) Generated Java code does not compile if struct contains fields that are all uppercase

     [ https://issues.apache.org/jira/browse/THRIFT-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-403.
--------------------------------

    Fix Version/s:     (was: 0.4)
       Resolution: Fixed

This issue isn't that much of a problem anymore, since I already implemented the "move field id constants down into a separate namespace" approach by doing the whole _Fields enum thing.

> Generated Java code does not compile if struct contains fields that are all uppercase
> -------------------------------------------------------------------------------------
>
>                 Key: THRIFT-403
>                 URL: https://issues.apache.org/jira/browse/THRIFT-403
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>    Affects Versions: 0.1
>         Environment: OS X 10.5
>            Reporter: Mathias Herberts
>
> Generated Java code contains definition of field ids which are integer static fields whose names are those of their associated field turned to uppercase.
> This is fine as long as no struct field is all uppercase, if one such field exists, the generated code won't compile as the same field will be defined twice in the generated class.
> This could be solved by either making the compiler complain of uppercase fields in the struct (no suitable I'd say) or generating a field id name that contains a prefix or suffix which will make sure the name won't be the same as the associated field.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.