[GitHub] [hbase] mattf-apache commented on pull request #1643: HBASE-24318 Create-release scripts fixes and enhancements

[GitBox <gi...@apache.org>]

mattf-apache commented on pull request #1643:
URL: https://github.com/apache/hbase/pull/1643#issuecomment-624188067


   @saintstack , thank you for the thorough review, I will respond to all comments momentarily.
   
   @busbey , I'd be delighted to have you use it.  This can be done two ways:
   - We can commit this patch as is, and fix any issues as new bugs.  This has the benefit that the improved tools will be included in the 3.0.0-alpha-1 release.
   - Or you can take advantage of the fact that these tools don't use the workspace they are called from.  Instead, they always create a clean workspace directory, and into that they pull a fresh "official" copy of the code from gitbox.apache.org, at the branch being built.  Since the invoking workspace won't be used in the build, you can just apply this patch to a private workspace, or clone https://github.com/mattf-apache/hbase/ and checkout branch `release-tool-enhancements`, and invoke the tools from there.  Then we can keep this PR open, and only commit it after your test.
   
   In either case, I'd be happy to respond promptly to any problems you find.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org