[GitHub] [spark] databricks-david-lewis commented on a diff in pull request #39808: [SPARK-41970][FOLLOWUP] Revert SparkPath changes to FileIndex and FileRelation

["databricks-david-lewis (via GitHub)" <gi...@apache.org>]

databricks-david-lewis commented on code in PR #39808:
URL: https://github.com/apache/spark/pull/39808#discussion_r1090969348


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningAwareFileIndex.scala:
##########
@@ -137,8 +137,8 @@ abstract class PartitioningAwareFileIndex(
   }
 
   /** Returns the list of files that will be read when scanning this relation. */
-  override def inputFiles: Array[SparkPath] =
-    allFiles().map(SparkPath.fromFileStatus).toArray
+  override def inputFiles: Array[String] =
+    allFiles().map(fs => SparkPath.fromFileStatus(fs).urlEncoded).toArray

Review Comment:
   Ah good point. It is not exactly a revert, but is reusing the SparkPath code to translate from hadoop `FileStatus` to url-encoded string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org