You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/08/23 23:45:35 UTC
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14131
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
IMPALA-7604: part 1: tests for agg cardinality
Add tests that demonstrate bugs with overflow and
multiple aggregation classes and provide a baseline
to demonstrate the effects of the bugfixes.
Testing:
Added planner tests:
* Cardinality estimates with multiple groups (both grouping and
non-grouping aggs).
* Overflow case from multiplication of grouping expr cardinality.
* Overflow handling of addition of multiple groups.
Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
---
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test
2 files changed, 667 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14131/1
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
IMPALA-7604: part 1: tests for agg cardinality
Add tests that demonstrate bugs with overflow and
multiple aggregation classes and provide a baseline
to demonstrate the effects of the bugfixes.
Testing:
Added planner tests:
* Cardinality estimates with multiple groups (both grouping and
non-grouping aggs).
* Overflow case from multiplication of grouping expr cardinality.
* Overflow handling of addition of multiple groups.
Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Reviewed-on: http://gerrit.cloudera.org:8080/14131
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test
2 files changed, 669 insertions(+), 0 deletions(-)
Approvals:
Bikramjeet Vig: Looks good to me, approved
Tim Armstrong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 6: Verified+1
Follow-on patch passed precommit, will apply verification to this too.
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 22:52:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4404/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 00:34:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14131
to look at the new patch set (#2).
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
IMPALA-7604: part 1: tests for agg cardinality
Add tests that demonstrate bugs with overflow and
multiple aggregation classes and provide a baseline
to demonstrate the effects of the bugfixes.
Testing:
Added planner tests:
* Cardinality estimates with multiple groups (both grouping and
non-grouping aggs).
* Overflow case from multiplication of grouping expr cardinality.
* Overflow handling of addition of multiple groups.
Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
---
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test
2 files changed, 668 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14131/2
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has removed a vote on this change.
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14131
to look at the new patch set (#4).
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
IMPALA-7604: part 1: tests for agg cardinality
Add tests that demonstrate bugs with overflow and
multiple aggregation classes and provide a baseline
to demonstrate the effects of the bugfixes.
Testing:
Added planner tests:
* Cardinality estimates with multiple groups (both grouping and
non-grouping aggs).
* Overflow case from multiplication of grouping expr cardinality.
* Overflow handling of addition of multiple groups.
Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
---
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
A testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test
2 files changed, 669 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/14131/4
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 2: Code-Review+2
Nice, thanks for adding some test coverage.
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 26 Aug 2019 16:11:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4353/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Aug 2019 00:44:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4862/
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 04:21:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 22:51:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14131/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java
File fe/src/test/java/org/apache/impala/planner/PlannerTest.java:
http://gerrit.cloudera.org:8080/#/c/14131/1/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@89
PS1, Line 89: * Cardinality for aggregatoins.
Oops, need to fix this typo in next PS.
http://gerrit.cloudera.org:8080/#/c/14131/1/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test
File testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test:
http://gerrit.cloudera.org:8080/#/c/14131/1/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test@106
PS1, Line 106: # cardinality.
input cardinality
http://gerrit.cloudera.org:8080/#/c/14131/1/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test@144
PS1, Line 144: # aggregation classes.
Should note that there's a bug here where aggregation classes are double-counted.
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 23 Aug 2019 23:47:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14131/3/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test
File testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test:
http://gerrit.cloudera.org:8080/#/c/14131/3/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test@397
PS3, Line 397: # Test overflow handling for single aggregation class.
nit: add
"# BUG: output cardinality overflows and is set to 0"
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 22:46:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14131/3/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test
File testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test:
http://gerrit.cloudera.org:8080/#/c/14131/3/testdata/workloads/functional-planner/queries/PlannerTest/card-agg.test@397
PS3, Line 397: # Test overflow handling for single aggregation class.
> nit: add
Done
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 27 Aug 2019 23:53:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4352/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 24 Aug 2019 00:26:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7604: part 1: tests for agg cardinality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14131 )
Change subject: IMPALA-7604: part 1: tests for agg cardinality
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4862/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14131
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59eaddbc5be253793293af064bb2d28a425564e1
Gerrit-Change-Number: 14131
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 00:16:57 +0000
Gerrit-HasComments: No