[GitHub] [pinot] walterddr commented on a diff in pull request #10858: [hotfix] use proper threadpool for test

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10858:
URL: https://github.com/apache/pinot/pull/10858#discussion_r1220061034


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/QueryServerEnclosure.java:
##########
@@ -69,7 +68,7 @@ public class QueryServerEnclosure {
   private final HelixManager _helixManager;
 
   private final QueryRunner _queryRunner;
-  private final ExecutorService _executor = Executors.newFixedThreadPool(ResourceManager.DEFAULT_QUERY_RUNNER_THREADS,
+  private final ExecutorService _executor = Executors.newCachedThreadPool(

Review Comment:
   technically only this one needs to be changed to cached threadpool. happy to only make this change if that makes more sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org