[GitHub] [pulsar] zymap commented on a change in pull request #9302: Add subscription backlog size info for topicstats.

[GitBox <gi...@apache.org>]

zymap commented on a change in pull request #9302:
URL: https://github.com/apache/pulsar/pull/9302#discussion_r563409871



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1826,6 +1826,13 @@
     )
     private boolean exposePreciseBacklogInPrometheus = false;
 
+    @FieldContext(
+            category = CATEGORY_METRICS,
+            doc = "Enable expose the backlog size fro each subscription when generating stats.\n" +
+                    " Locking is used for fetching the status so default to false."
+    )
+    private boolean exposeSubscriptionBacklokSizeInPrometheus = false;

Review comment:
       ```suggestion
       private boolean exposeSubscriptionBacklogSizeInPrometheus = false;
   ```

##########
File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -764,10 +766,11 @@ default void delete(String topic, boolean force) throws PulsarAdminException {
      * @throws PulsarAdminException
      *             Unexpected error
      */
-    TopicStats getStats(String topic, boolean getPreciseBacklog) throws PulsarAdminException;
+    TopicStats getStats(String topic, boolean getPreciseBacklog,

Review comment:
       I think we shouldn't change the original API, that's will bring the compatibility issue with the PulsarAdmin. Let's create a new API for this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org