You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ppalaga (via GitHub)" <gi...@apache.org> on 2023/04/29 13:13:28 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request, #4861: simple("${exchange.getMessage().getBody()}") causes a MethodNotFoundException in native mode
ppalaga opened a new pull request, #4861:
URL: https://github.com/apache/camel-quarkus/pull/4861
fix #4860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #4861: simple("${exchange.getMessage().getBody()}") causes a MethodNotFoundException in native mode
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #4861:
URL: https://github.com/apache/camel-quarkus/pull/4861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4861: simple("${exchange.getMessage().getBody()}") causes a MethodNotFoundException in native mode
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #4861:
URL: https://github.com/apache/camel-quarkus/pull/4861#discussion_r1181285955
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -139,6 +139,11 @@ void reflectiveItems(
.map(ai -> ai.target().asMethod())
.forEach(mi -> reflectiveMethod.produce(new ReflectiveMethodBuildItem(mi)));
+ reflectiveClass.produce(
+ ReflectiveClassBuildItem.builder(
+ "org.apache.camel.support.AbstractExchange",
+ org.apache.camel.support.MessageSupport.class.getName())
Review Comment:
No, I have not. Do you have any other scenarios in mind this is not covering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] turing85 commented on a diff in pull request #4861: simple("${exchange.getMessage().getBody()}") causes a MethodNotFoundException in native mode
Posted by "turing85 (via GitHub)" <gi...@apache.org>.
turing85 commented on code in PR #4861:
URL: https://github.com/apache/camel-quarkus/pull/4861#discussion_r1181305016
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -139,6 +139,11 @@ void reflectiveItems(
.map(ai -> ai.target().asMethod())
.forEach(mi -> reflectiveMethod.produce(new ReflectiveMethodBuildItem(mi)));
+ reflectiveClass.produce(
+ ReflectiveClassBuildItem.builder(
+ "org.apache.camel.support.AbstractExchange",
+ org.apache.camel.support.MessageSupport.class.getName())
Review Comment:
None I found. As I wrote in #4860 :
> ... This, however, begs the question: what else should be registered? We should analyze all relevant classes used by the `simple(...)` language and ensure that they all work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] turing85 commented on a diff in pull request #4861: simple("${exchange.getMessage().getBody()}") causes a MethodNotFoundException in native mode
Posted by "turing85 (via GitHub)" <gi...@apache.org>.
turing85 commented on code in PR #4861:
URL: https://github.com/apache/camel-quarkus/pull/4861#discussion_r1181077527
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -139,6 +139,11 @@ void reflectiveItems(
.map(ai -> ai.target().asMethod())
.forEach(mi -> reflectiveMethod.produce(new ReflectiveMethodBuildItem(mi)));
+ reflectiveClass.produce(
+ ReflectiveClassBuildItem.builder(
+ "org.apache.camel.support.AbstractExchange",
+ org.apache.camel.support.MessageSupport.class.getName())
Review Comment:
Have you checked whether there are possibly other classes that should be registered in order for the simple language to work as expected on the `exchange`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4861: simple("${exchange.getMessage().getBody()}") causes a MethodNotFoundException in native mode
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #4861:
URL: https://github.com/apache/camel-quarkus/pull/4861#discussion_r1181309747
##########
extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java:
##########
@@ -139,6 +139,11 @@ void reflectiveItems(
.map(ai -> ai.target().asMethod())
.forEach(mi -> reflectiveMethod.produce(new ReflectiveMethodBuildItem(mi)));
+ reflectiveClass.produce(
+ ReflectiveClassBuildItem.builder(
+ "org.apache.camel.support.AbstractExchange",
+ org.apache.camel.support.MessageSupport.class.getName())
Review Comment:
Thanks for explaining. Yeah, it would be nice to audit whether we need more. While I do not feel like I have free capacity do that these days, we can still keep the issue open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org