You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org> on 2023/08/24 22:50:25 UTC
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Sai Hemanth Gantasala has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20420
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M tests/custom_cluster/test_events_custom_configs.py
2 files changed, 35 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/1
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/13836/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 24 Aug 2023 23:07:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 5:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/13871/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Aug 2023 18:39:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20420
to look at the new patch set (#8).
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
6 files changed, 80 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/8
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 8
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 10:
> Patch Set 10:
>
> > Patch Set 10: Verified-1
> >
> > Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9690/
>
> These is a failure that might due to this patch. Please take a look:
> https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/321
>
> custom_cluster/test_metastore_service.py:405: in test_fallback_get_partitions_by_names
> TestMetastoreService.part_tbl, valid_part_names, True)
> custom_cluster/test_metastore_service.py:1207: in __run_partitions_by_names_tests
> "Internal error")
> custom_cluster/test_metastore_service.py:1289: in __get_parts_by_names_expect_exception
> assert expected_exception_str in str(e)
> E assert 'Internal error' in "InvalidObjectException(message='hive.test_fallback_get_partitions_by_names_efbbe23c.table-does-not-exist table not found')"
> E + where "InvalidObjectException(message='hive.test_fallback_get_partitions_by_names_efbbe23c.table-does-not-exist table not found')" = str(InvalidObjectException(message='hive.test_fallback_get_partitions_by_names_efbbe23c.table-does-not-exist table not found'))
True. The test should now expect a 'InvalidObjectException' instead of 'Internal error' error message.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 10
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Sep 2023 21:52:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 9: Code-Review+2
LGTM. Carrying Michael's +1.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 9
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Sep 2023 10:05:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20420/8/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:
http://gerrit.cloudera.org:8080/#/c/20420/8/tests/custom_cluster/test_events_custom_configs.py@522
PS8, Line 522: self.client.execute("refresh {}.{}".format(unique_database, test_table))
: self.run_stmt_in_hive(
: "insert into {}.{} partition(year=2023) values (4),(5),(6)"
: .format(unique_database, test_table))
: data = FireEventRequestData()
: if is_insert:
: insert_data = InsertEventRequestData()
: insert_data.filesAdded = "/warehouse/mytable/b1"
: insert_data.replace = False
: data.insertData = insert_data
: else:
: data.refreshEvent = True
: req = FireEventRequest(True, data)
: req.dbName = unique_database
: req.tableName = test_table
: req.partitionVals = ["2023"]
: self.hive_client.fire_listener_event(req)
: self.run_stmt_in_hive(
: "drop table {}.{}".format(unique_database, test_table))
Too many statements here to finish in 5s. This test always passes in my env without the fix. Let's bump hms_event_polling_interval_s to 10 so it can always fails before we merge this fix.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 8
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Sep 2023 00:31:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20420
to look at the new patch set (#6).
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
4 files changed, 47 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/6
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 6
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13903/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 8
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 20:02:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 10: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9690/
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 10
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Sep 2023 14:34:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20420
to look at the new patch set (#7).
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
5 files changed, 51 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/7
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 7
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/13852/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Sat, 26 Aug 2023 17:43:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9704/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 12
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Sep 2023 05:09:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 10:
> Patch Set 10: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9690/
These is a failure that might due to this patch. Please take a look:
https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/321
custom_cluster/test_metastore_service.py:405: in test_fallback_get_partitions_by_names
TestMetastoreService.part_tbl, valid_part_names, True)
custom_cluster/test_metastore_service.py:1207: in __run_partitions_by_names_tests
"Internal error")
custom_cluster/test_metastore_service.py:1289: in __get_parts_by_names_expect_exception
assert expected_exception_str in str(e)
E assert 'Internal error' in "InvalidObjectException(message='hive.test_fallback_get_partitions_by_names_efbbe23c.table-does-not-exist table not found')"
E + where "InvalidObjectException(message='hive.test_fallback_get_partitions_by_names_efbbe23c.table-does-not-exist table not found')" = str(InvalidObjectException(message='hive.test_fallback_get_partitions_by_names_efbbe23c.table-does-not-exist table not found'))
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 10
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Sep 2023 00:27:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 12
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Sep 2023 23:27:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 11
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Sep 2023 21:53:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 9:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13945/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 9
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Sep 2023 01:59:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Reviewed-on: http://gerrit.cloudera.org:8080/20420
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
M tests/custom_cluster/test_metastore_service.py
7 files changed, 81 insertions(+), 15 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 13
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20420
to look at the new patch set (#11).
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
M tests/custom_cluster/test_metastore_service.py
7 files changed, 81 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/11
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 11
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 7:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@508
PS7, Line 508: # IMPALA-11768 -- Insert partition events should be ignored
> Could you split this into another test since it's a separated issue?
Ack
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@512
PS7, Line 512: "insert into {}.{} partition(year=2023) values (1,2)"
> This is a new partition. I don't see an INSERT event is generated. Instead,
I overlooked this point. Add a insert event in the latest patch
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@517
PS7, Line 517: assert EventProcessorUtils.get_event_processor_status() == "ACTIVE"
> Shouldn't we need Impala side changes to catch the InvalidObjectException t
Ack
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@519
PS7, Line 519:
> nit: two blank lines here. Let's keep one.
Ack
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 7
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 19:36:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 4:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/13866/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Aug 2023 02:03:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20420
to look at the new patch set (#2).
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M java/shaded-deps/hive-exec/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
3 files changed, 39 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/2
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 11:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/13975/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 11
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Sep 2023 22:17:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 10:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9690/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 10
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Sep 2023 10:06:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 10
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Sep 2023 10:06:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9702/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 12
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Sep 2023 23:27:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 7:
(4 comments)
LGTM. Just have some minor comments on the test.
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@508
PS7, Line 508: # IMPALA-11768 -- Insert partition events should be ignored
Could you split this into another test since it's a separated issue?
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@512
PS7, Line 512: "insert into {}.{} partition(year=2023) values (1,2)"
This is a new partition. I don't see an INSERT event is generated. Instead, there is only one ADD_PARTITION event.
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@517
PS7, Line 517: assert EventProcessorUtils.get_event_processor_status() == "ACTIVE"
Shouldn't we need Impala side changes to catch the InvalidObjectException to make this work? Just afraid this will be flaky.
http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@519
PS7, Line 519:
nit: two blank lines here. Let's keep one.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 7
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Aug 2023 01:46:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20420
to look at the new patch set (#5).
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M fe/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
4 files changed, 43 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/5
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 5
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 6:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/13872/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 6
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Aug 2023 19:04:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13876/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 7
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Aug 2023 21:58:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20420
to look at the new patch set (#4).
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M java/shaded-deps/hive-exec/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
3 files changed, 43 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/4
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 4
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/13865/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Aug 2023 01:14:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20420
to look at the new patch set (#3).
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M java/shaded-deps/hive-exec/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
3 files changed, 39 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/3
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 3
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 12: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9702/
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 12
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Sep 2023 03:59:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 12
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Sep 2023 09:36:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 8
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Sep 2023 16:25:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20420/8/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:
http://gerrit.cloudera.org:8080/#/c/20420/8/tests/custom_cluster/test_events_custom_configs.py@522
PS8, Line 522: self.client.execute("refresh {}.{}".format(unique_database, test_table))
: self.run_stmt_in_hive(
: "insert into {}.{} partition(year=2023) values (4),(5),(6)"
: .format(unique_database, test_table))
: data = FireEventRequestData()
: if is_insert:
: insert_data = InsertEventRequestData()
: insert_data.filesAdded = "/warehouse/mytable/b1"
: insert_data.replace = False
: data.insertData = insert_data
: else:
: data.refreshEvent = True
: req = FireEventRequest(True, data)
: req.dbName = unique_database
: req.tableName = test_table
: req.partitionVals = ["2023"]
: self.hive_client.fire_listener_event(req)
: self.run_stmt_in_hive(
: "drop table {}.{}".format(unique_database, test_table))
> Too many statements here to finish in 5s. This test always passes in my env
Ack
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 9
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Sep 2023 01:34:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes
Posted by "Sai Hemanth Gantasala (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20420
to look at the new patch set (#9).
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes
......................................................................
IMPALA-12231: Bump GBN to get HMS thrift API changes
We need a couple of hive changes HIVE-27319 and HIVE-27337 for catalogD
to work with latest HMS server to fix IMPALA-11768 and IMPALA-11939
respectively.
Bump CDP_BUILD_NUMBER (GBN) to 44206393
Bump various CDP versiona numbers to be based on 7.2.18.0-273
TESTING: Exhaustive tests ran clean
Added a couple of tests for IMPALA-11939 and IMPALA-11768
Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
M java/shaded-deps/hive-exec/pom.xml
M java/test-hive-udfs/pom.xml
M tests/custom_cluster/test_events_custom_configs.py
6 files changed, 80 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/20420/9
--
To view, visit http://gerrit.cloudera.org:8080/20420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3
Gerrit-Change-Number: 20420
Gerrit-PatchSet: 9
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>