You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zy-kkk (via GitHub)" <gi...@apache.org> on 2024/10/31 08:03:06 UTC

[PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

zy-kkk opened a new pull request, #42995:
URL: https://github.com/apache/doris/pull/42995

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42995:
URL: https://github.com/apache/doris/pull/42995#issuecomment-2449269805

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #42995:
URL: https://github.com/apache/doris/pull/42995#issuecomment-2449278279

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42995:
URL: https://github.com/apache/doris/pull/42995#issuecomment-2449361404

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.71 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 2893d89e6a6cb8daaaffa1288df0752fe3762211, data reload: false
   
   query1	0.03	0.02	0.03
   query2	0.07	0.03	0.03
   query3	0.23	0.06	0.06
   query4	1.64	0.10	0.10
   query5	0.41	0.38	0.39
   query6	1.13	0.66	0.65
   query7	0.02	0.01	0.01
   query8	0.04	0.03	0.03
   query9	0.57	0.50	0.50
   query10	0.56	0.55	0.54
   query11	0.14	0.10	0.10
   query12	0.14	0.11	0.11
   query13	0.61	0.59	0.60
   query14	2.68	2.86	2.72
   query15	0.91	0.84	0.82
   query16	0.40	0.37	0.39
   query17	1.04	1.05	1.06
   query18	0.20	0.20	0.20
   query19	1.99	1.75	1.93
   query20	0.01	0.01	0.01
   query21	15.35	0.60	0.59
   query22	2.86	2.26	1.71
   query23	16.85	0.96	0.83
   query24	3.02	1.24	1.58
   query25	0.20	0.12	0.15
   query26	0.54	0.14	0.14
   query27	0.05	0.05	0.04
   query28	9.97	1.09	1.06
   query29	12.57	3.29	3.26
   query30	0.24	0.06	0.06
   query31	2.88	0.39	0.38
   query32	3.26	0.45	0.45
   query33	2.95	3.03	3.03
   query34	16.95	4.50	4.47
   query35	4.52	4.53	4.54
   query36	0.67	0.47	0.48
   query37	0.08	0.06	0.05
   query38	0.04	0.03	0.04
   query39	0.04	0.02	0.02
   query40	0.15	0.13	0.12
   query41	0.07	0.02	0.02
   query42	0.03	0.02	0.02
   query43	0.04	0.03	0.03
   Total cold run time: 106.15 s
   Total hot run time: 32.71 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42995:
URL: https://github.com/apache/doris/pull/42995#issuecomment-2449289113

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42995:
URL: https://github.com/apache/doris/pull/42995#issuecomment-2449273039

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42995:
URL: https://github.com/apache/doris/pull/42995#issuecomment-2449266217

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk merged PR #42995:
URL: https://github.com/apache/doris/pull/42995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42995:
URL: https://github.com/apache/doris/pull/42995#issuecomment-2449329501

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41054 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 2893d89e6a6cb8daaaffa1288df0752fe3762211, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17601	7421	7256	7256
   q2	2047	166	156	156
   q3	10582	1076	1166	1076
   q4	10588	851	920	851
   q5	7721	3082	3023	3023
   q6	235	144	147	144
   q7	1038	594	604	594
   q8	9353	1942	2008	1942
   q9	6565	6409	6458	6409
   q10	7042	2414	2407	2407
   q11	442	247	242	242
   q12	402	210	206	206
   q13	17776	3022	2977	2977
   q14	252	208	208	208
   q15	582	514	517	514
   q16	621	580	584	580
   q17	956	604	540	540
   q18	7306	6608	6782	6608
   q19	1339	1032	1018	1018
   q20	482	178	177	177
   q21	3980	3268	3143	3143
   q22	1132	1033	983	983
   Total cold run time: 108042 ms
   Total hot run time: 41054 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7312	7310	7244	7244
   q2	319	227	229	227
   q3	2942	2925	2918	2918
   q4	2119	1871	1819	1819
   q5	5701	5697	5758	5697
   q6	231	144	140	140
   q7	2247	1826	1821	1821
   q8	3340	3511	3424	3424
   q9	8950	8919	8883	8883
   q10	3575	3573	3540	3540
   q11	578	480	478	478
   q12	831	665	612	612
   q13	9690	3245	3194	3194
   q14	301	293	275	275
   q15	578	535	532	532
   q16	704	658	656	656
   q17	1846	1618	1595	1595
   q18	8282	7961	7666	7666
   q19	1721	1534	1619	1534
   q20	2154	1843	1894	1843
   q21	5715	5323	5478	5323
   q22	1131	1085	1053	1053
   Total cold run time: 70267 ms
   Total hot run time: 60474 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42995:
URL: https://github.com/apache/doris/pull/42995#issuecomment-2449323276

   TeamCity be ut coverage result:
    Function Coverage: 37.93% (9847/25959) 
    Line Coverage: 29.19% (82058/281105)
    Region Coverage: 28.44% (42332/148855)
    Branch Coverage: 25.02% (21509/85984)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/2893d89e6a6cb8daaaffa1288df0752fe3762211_2893d89e6a6cb8daaaffa1288df0752fe3762211/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](build) add macro guard for hdfs.h to fix build error on Mac [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42995:
URL: https://github.com/apache/doris/pull/42995#issuecomment-2449351793

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 195865 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 2893d89e6a6cb8daaaffa1288df0752fe3762211, data reload: false
   
   query1	1214	924	900	900
   query2	6224	2122	2041	2041
   query3	10890	4166	4175	4166
   query4	68284	29707	23531	23531
   query5	4930	431	421	421
   query6	395	164	165	164
   query7	5639	287	298	287
   query8	311	226	225	225
   query9	9347	2766	2749	2749
   query10	438	257	245	245
   query11	17473	15334	15708	15334
   query12	160	103	105	103
   query13	1576	432	435	432
   query14	10497	7525	6741	6741
   query15	207	182	181	181
   query16	7067	459	493	459
   query17	1023	551	560	551
   query18	1808	292	290	290
   query19	190	150	146	146
   query20	114	110	111	110
   query21	196	100	100	100
   query22	4707	4365	4458	4365
   query23	34648	34174	34213	34174
   query24	6061	2830	2837	2830
   query25	506	394	396	394
   query26	648	158	159	158
   query27	1705	278	287	278
   query28	4466	2471	2460	2460
   query29	678	415	416	415
   query30	236	153	156	153
   query31	975	797	815	797
   query32	67	52	58	52
   query33	393	268	271	268
   query34	918	509	513	509
   query35	852	737	729	729
   query36	1076	960	960	960
   query37	113	72	77	72
   query38	4460	4217	4183	4183
   query39	1481	1399	1436	1399
   query40	199	98	98	98
   query41	47	47	45	45
   query42	111	98	96	96
   query43	539	476	506	476
   query44	1164	829	830	829
   query45	183	166	170	166
   query46	1117	694	713	694
   query47	1986	1844	1892	1844
   query48	417	325	326	325
   query49	748	397	393	393
   query50	813	412	383	383
   query51	7283	7148	7125	7125
   query52	102	95	87	87
   query53	245	180	179	179
   query54	527	408	393	393
   query55	79	75	78	75
   query56	259	242	276	242
   query57	1301	1211	1196	1196
   query58	206	199	195	195
   query59	3280	3134	2945	2945
   query60	269	256	244	244
   query61	98	101	98	98
   query62	789	688	670	670
   query63	213	184	184	184
   query64	1347	643	586	586
   query65	3308	3239	3177	3177
   query66	693	331	299	299
   query67	15933	15698	15697	15697
   query68	3482	575	585	575
   query69	409	248	249	248
   query70	1205	1077	1120	1077
   query71	346	254	242	242
   query72	6162	4095	3906	3906
   query73	750	355	354	354
   query74	9971	8929	8971	8929
   query75	3384	2643	2663	2643
   query76	1815	1028	1030	1028
   query77	499	279	274	274
   query78	10284	9406	9372	9372
   query79	1524	614	586	586
   query80	867	415	434	415
   query81	530	232	238	232
   query82	1315	111	114	111
   query83	185	143	131	131
   query84	272	69	66	66
   query85	878	290	286	286
   query86	345	300	298	298
   query87	4947	4692	4642	4642
   query88	3578	2193	2168	2168
   query89	415	287	288	287
   query90	1998	184	187	184
   query91	141	100	99	99
   query92	68	48	51	48
   query93	1983	547	552	547
   query94	777	290	300	290
   query95	337	239	243	239
   query96	623	282	282	282
   query97	2934	2674	2715	2674
   query98	214	207	204	204
   query99	1617	1317	1315	1315
   Total cold run time: 319084 ms
   Total hot run time: 195865 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org