[GitHub] [spark] gengliangwang commented on a diff in pull request #39096: [SPARK-41421][UI] Protobuf serializer for ApplicationEnvironmentInfoWrapper

[GitBox <gi...@apache.org>]

gengliangwang commented on code in PR #39096:
URL: https://github.com/apache/spark/pull/39096#discussion_r1051188448


##########
core/src/main/protobuf/org/apache/spark/status/protobuf/store_types.proto:
##########
@@ -106,3 +106,45 @@ message TaskDataWrapper {
   int64 stage_id = 40;
   int32 stage_attempt_id = 41;
 }
+
+message ExecutorResourceRequest {
+  string resource_name = 1;
+  int64 amount = 2;
+  string discoveryScript = 3;
+  string vendor = 4;
+}
+
+message TaskResourceRequest {
+  string resource_name = 1;
+  double amount = 2;
+}
+
+message ResourceProfileInfo {
+  int32 id = 1;
+  map<string, ExecutorResourceRequest> executor_resources = 2;
+  map<string, TaskResourceRequest> task_resources = 3;
+}
+
+message RuntimeInfo {
+  string java_version = 1;
+  string java_home = 2;
+  string scala_version = 3;
+}
+
+message ApplicationEnvironmentInfo {
+  message PairSS {

Review Comment:
   Shall we name it `PairStrings` and move it out of `ApplicationEnvironmentInfo`? In the future this might be reused.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org