You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/01/12 04:19:09 UTC

[GitHub] [incubator-dolphinscheduler] dailidong edited a comment on pull request #4299: [Improvement][*] Refactor code to fix code smell and vulnerability

dailidong edited a comment on pull request #4299:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4299#issuecomment-758386182


   > What part should I split into another PR. The test coverage needs to be increased to at least 33% to pass sonar check. Should I leave test coverage out of this PR?
   
   you can split it according the module, like dolphinscheduler-alert、dolphinscheduler-api and so on.  just remember don't includes too many files in one PR. because review these files will be difficult 
   
   please contact me (lidongdai@apache.org) when meeting any problem 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org