You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2024/09/25 14:30:45 UTC
[kudu-CR](branch-1.17.x) [Python] Update dependencies and 3.10 support
Hello Zoltan Martonka, Attila Bukor,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/21853
to review the following change.
Change subject: [Python] Update dependencies and 3.10 support
......................................................................
[Python] Update dependencies and 3.10 support
This patch updates the package dependencies to clearly define the
supported Python versions. Previously, supported versions were
determined through trial and error (KUDU-2951). With this update, the
following versions are now explicitly supported:
- Python 2.7
- Python 3.6 to 3.10 (inclusive)
This patch adds support for the newer Python versions 3.9 and 3.10.
Support for Python versions 3.0 to 3.5 has been discontinued due to
dependency complications in this range. However, this decision can be
revisited based on community feedback. To re-add support for these
versions, use the following marker in `setup.py` and `requirements.txt`:
'python_version >= 3.0, < 3.6'.
Testing was conducted manually on:
- Ubuntu 20: Python 2.7, Python 3.6 to 3.10
- SLES 15 SP5: Python 3.10
The `setup.py` file has been updated to reflect these changes,
ensuring the correct versions are visible on PyPI upon the next release.
Change-Id: I930a15018158563996819fb33d32a3bb5641c396
Reviewed-on: http://gerrit.cloudera.org:8080/21380
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
---
M python/requirements.txt
M python/setup.py
2 files changed, 29 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/21853/1
--
To view, visit http://gerrit.cloudera.org:8080/21853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396
Gerrit-Change-Number: 21853
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR](branch-1.17.x) [Python] Update dependencies and 3.10 support
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21853 )
Change subject: [Python] Update dependencies and 3.10 support
......................................................................
Patch Set 1: Verified+1
unrelated test failure: tsan: auto_leader_rebalancer-test.0
--
To view, visit http://gerrit.cloudera.org:8080/21853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396
Gerrit-Change-Number: 21853
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Sep 2024 16:43:41 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [Python] Update dependencies and 3.10 support
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21853 )
Change subject: [Python] Update dependencies and 3.10 support
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/543/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396
Gerrit-Change-Number: 21853
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Sep 2024 16:23:08 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [Python] Update dependencies and 3.10 support
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21853 )
Change subject: [Python] Update dependencies and 3.10 support
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396
Gerrit-Change-Number: 21853
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2024 16:02:18 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [Python] Update dependencies and 3.10 support
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21853 )
Change subject: [Python] Update dependencies and 3.10 support
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/543/
--
To view, visit http://gerrit.cloudera.org:8080/21853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396
Gerrit-Change-Number: 21853
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Sep 2024 14:30:51 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [Python] Update dependencies and 3.10 support
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21853 )
Change subject: [Python] Update dependencies and 3.10 support
......................................................................
[Python] Update dependencies and 3.10 support
This patch updates the package dependencies to clearly define the
supported Python versions. Previously, supported versions were
determined through trial and error (KUDU-2951). With this update, the
following versions are now explicitly supported:
- Python 2.7
- Python 3.6 to 3.10 (inclusive)
This patch adds support for the newer Python versions 3.9 and 3.10.
Support for Python versions 3.0 to 3.5 has been discontinued due to
dependency complications in this range. However, this decision can be
revisited based on community feedback. To re-add support for these
versions, use the following marker in `setup.py` and `requirements.txt`:
'python_version >= 3.0, < 3.6'.
Testing was conducted manually on:
- Ubuntu 20: Python 2.7, Python 3.6 to 3.10
- SLES 15 SP5: Python 3.10
The `setup.py` file has been updated to reflect these changes,
ensuring the correct versions are visible on PyPI upon the next release.
Change-Id: I930a15018158563996819fb33d32a3bb5641c396
Reviewed-on: http://gerrit.cloudera.org:8080/21380
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/21853
Reviewed-by: Marton Greber <gr...@gmail.com>
---
M python/requirements.txt
M python/setup.py
2 files changed, 29 insertions(+), 34 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396
Gerrit-Change-Number: 21853
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR](branch-1.17.x) [Python] Update dependencies and 3.10 support
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: [Python] Update dependencies and 3.10 support
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I930a15018158563996819fb33d32a3bb5641c396
Gerrit-Change-Number: 21853
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>