[jira] [Commented] (SAMZA-2022) Startpoints - SystemConsumers (not to be confused with SystemConsumer) modifications including integration with MessageChooser.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727130#comment-16727130 ] 

ASF GitHub Bot commented on SAMZA-2022:
---------------------------------------

GitHub user dnishimura opened a pull request:

    https://github.com/apache/samza/pull/869

    SAMZA-2022: Integrate startpoints with SystemConsumers

    This PR integrates the `Startpoint` with the `SystemConsumers` multiplexer class. The general logic is if there is a `Startpoint` for an SSP in a task and the `SystemConsumer` implements the `StartpointVisitor` interface, it will apply the visitor method via `Startpoint#apply(SystemStreamPartition, StartpointVisitor)`. Otherwise, the `SystemConsumer#register(SystemStreamPartition, checkpointOffset:String)` method is called as it currently does.
    
    @shanthoosh @cameronlee314 @prateekm - Please take a look... after the break is fine. If I don't respond to comments within 24-48 hours during my leave, please feel free to hijack this PR into another PR. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dnishimura/samza samza-2022-startpoint-systemconsumers-integ

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/869.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #869
    
----
commit 2aa244e8cdfdecd88aeba1c2be38acbb8cef5ac2
Author: Daniel Nishimura <dn...@...>
Date:   2018-12-20T20:09:36Z

    SAMZA-2022: Integrate startpoints with SystemConsumers

----


> Startpoints - SystemConsumers (not to be confused with SystemConsumer) modifications including integration with MessageChooser.
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SAMZA-2022
>                 URL: https://issues.apache.org/jira/browse/SAMZA-2022
>             Project: Samza
>          Issue Type: New Feature
>    Affects Versions: 1.1
>            Reporter: Daniel Nishimura
>            Assignee: Daniel Nishimura
>            Priority: Major
>
> SystemConsumers multiplexes the register with offset calls to each SystemConsumer. The basic logic that is needed in register() is
> {noformat}
> if there is a startpoint for the SSP and the SystemConsumer implements StartpointVisitor
>     call SystemConsumer#visit(SSP, Startpoint)
> else
>     call SystemConsumer#register(SSP, checkpointOffset:String){noformat}
> Part of this is to also investigate how startpoints affects the MessageChooser logic.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)