[GitHub] [spark] sujith71955 commented on a change in pull request #24489: [SPARK-27555][SQL]HiveSerDe should fall back to hadoopconf if hive.default.fileformat is not found in SQLConf

[GitBox <gi...@apache.org>]

sujith71955 commented on a change in pull request #24489: [SPARK-27555][SQL]HiveSerDe should fall back to hadoopconf if  hive.default.fileformat is not found in SQLConf
URL: https://github.com/apache/spark/pull/24489#discussion_r280859062
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala
 ##########
 @@ -88,7 +89,16 @@ object HiveSerDe {
   }
 
   def getDefaultStorage(conf: SQLConf): CatalogStorageFormat = {
-    val defaultStorageType = conf.getConfString("hive.default.fileformat", "textfile")
+    // To respect hive-site.xml, it peeks Hadoop configuration from existing Spark session,
 
 Review comment:
   Small correction is required in comments
   Nit: it picks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org