[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2855: HDDS-6019. Fix s3g create key error in cluster with replication one.

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2855:
URL: https://github.com/apache/ozone/pull/2855#discussion_r755600417



##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/S3StorageType.java
##########
@@ -48,8 +50,17 @@ public ReplicationType getType() {
     return type;
   }
 
-  public static S3StorageType getDefault() {
-    return STANDARD;
+  public static S3StorageType getDefault(ConfigurationSource config) {

Review comment:
       Can we add JavaDoc for this.
   
   And also what is the reason if config has wrong value, falling back to STANDARD?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org